Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft 0.30.1 #2392

Closed
wants to merge 164 commits into from
Closed

Draft 0.30.1 #2392

wants to merge 164 commits into from

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Jan 13, 2024

WARNING: ☠️ do not merge this branch into your development branches and do not rely on it being stable. ☠️

contains:

  • MASP Bug Fixes #2371 - evil 2063358 and 8aa6639 (rerun on release with make -C wasm_for_tests/wasm_source)
  • Modularization: core refactors #2312 - evil 14b80a0
  • move crates into crates dir #2386
    • rerere doesn't work on some conflicts:
      • just git add at the suggested path:
        • CONFLICT (file location): ethereum_bridge/src/protocol/validation.rs added in HEAD inside a directory that was renamed in origin/tomas/crates-dir, suggesting it should perhaps be moved to crates/ethereum_bridge/src/protocol/validation.rs.
        • CONFLICT (file location): ethereum_bridge/src/protocol/validation/bridge_pool_roots.rs added in HEAD inside a directory that was renamed in origin/tomas/crates-dir, suggesting it should perhaps be moved to crates/ethereum_bridge/src/protocol/validation/bridge_pool_roots.rs.
        • CONFLICT (file location): ethereum_bridge/src/protocol/validation/ethereum_events.rs added in HEAD inside a directory that was renamed in origin/tomas/crates-dir, suggesting it should perhaps be moved to crates/ethereum_bridge/src/protocol/validation/ethereum_events.rs.
        • CONFLICT (file location): ethereum_bridge/src/protocol/validation/validator_set_update.rs added in HEAD inside a directory that was renamed in origin/tomas/crates-dir, suggesting it should perhaps be moved to crates/ethereum_bridge/src/protocol/validation/validator_set_update.rs.
        • CONFLICT (file location): ibc/src/actions.rs added in HEAD inside a directory that was renamed in origin/tomas/crates-dir, suggesting it should perhaps be moved to crates/ibc/src/actions.rs.
      • dead code, should be git rm'ed
        • CONFLICT (rename/delete): vp_prelude/src/key.rs renamed to crates/vp_prelude/src/key.rs in origin/tomas/crates-dir, but deleted in HEAD.
        • CONFLICT (rename/delete): vp_prelude/src/token.rs renamed to crates/vp_prelude/src/token.rs in origin/tomas/crates-dir, but deleted in HEAD.
  • Mandatory CometBFT timestamp #2383
  • Sets gas sentinel in ibc_tx_charge_gas #2395
  • Fix E2E test for PGF over IBC by waiting before the balance check #2398
  • Fee validation refactor #2382 - evil 732bbb6
  • sdk: more rpc #2400 - evil eefe4c0

queue (unordered):

Gianmarco Fraccaroli and others added 21 commits January 15, 2024 16:36
…ow the unshielding of unepoched assets in any epoch.
* origin/murisi/masp-fixes:
  Prevent the backdating of transparent inputs. Be more liberal and allow the unshielding of unepoched assets in any epoch.
  Added support for non-timestamped assets.
  Added changelog entry.
  Unified the functions that construct AssetType to ensure encoding consistency.
  Fixed the printing of shielded balance for specific token across users.
  Improve the handling of trace amounts during conversions of assets to older epochs.
  Shielded balance printing now includes trace assets.
  Allow notes containing older epochs to be spent.
  Use a note only if theres a shortfall and it would help close it.
  Stop creating redundant transaction descriptors.
  Redefined MaspAmount using the ValueSum type from the MASP crate.
  Removed now redundant operations on MaspAmount.
  Reduce the amount of decoding and encoding of AssetTypes.
  Refactored the validation of shielded transaction transparent outputs. Now avoid assuming that transparent outputs are ordered. Avoid assuming that there must be transparent outputs. Ensure that total of transparent output values match the containing transaction. Increased the validation of transparent inputs to be similar to that of transparent outputs.
* origin/tomas+tiago/modularization: (118 commits)
  changelog: add #2312
  add impl for VP get_pred_epochs
  pos_queries: remove unused methods
  fix masp storage key regression
  undo reintroduced typos
  fix `get_current_decision_height` by moving it to WlStorage
  vm_env: add `tx_get_pred_epoch` impl
  fix rustdocs
  macros: fix tests
  fix the shell test_queries
  fix TxGasMeter construction from GasLimit
  wasm: fix tests
  fix shared/sdk build without rand
  ethereum_bridge: fix build with "testing" feature
  various fixes
  tests: fix build
  benches: fix build
  apps: fix tests
  make -C wasm_for_tests
  rm ethereum_bridge dep from tx_prelude
  tidy up feature flags to avoid wasm-bindgen in wasm crates
  shared: fix tests
  sdk: fix tests
  ibc: fix tests
  ethereum_bridge: fix tests
  proof_of_stake: fix tests
  shielded_token: fix tests
  state: fix tests
  parameters: fix warning
  account: fix tests
  vote_ext: fix tests
  tx: fix tests
  gas: fix tests
  merkle_tree: fix tests
  rename struct Storage to State
  storage: fix tests
  move types, trait DB and MockDB impl from state to storage
  core: fix tests
  wasm: update lock file
  wasm_for_tests: fix build
  light_sdk: fix build
  encoding_spec: fix build
  apps: fix build
  shared: fix build
  wasm: fix build
  sdk: fix build
  token: add common `write_params` fn
  0.29 rebase fixes
  add namada_token crate
  vp_prelude: fix build
  tx_prelude: fix build
  shielded_token: fix build
  tx_env: fix build
  ibc: fix build
  ethereum_bridge: fix build
  ethereum_bridge: use the original name for wrapped erc20s
  state: fix build
  merkle_tree: fix build
  vote_ext: fix build
  storage: refactor new fns in StorageRead using pred `Epochs`
  proof_of_stake: fix build
  rebase fixes
  merkle_tree: wip fix build
  proof_of_stake: wip fix build
  move ics23_specs from state into merkle_tree
  governance: fix build
  account: fix build
  macros: use full paths types used in `derive(StorageKeys)`
  trans_token: fix build
  tx: wip fix build
  move vote_ext tx data types from tx to vote_ext crate
  gas: fix build
  parameters: fix build
  move collection validation helpers into vp_env crate
  mv proto symlink to namada_tx
  move collection validation helpers from storage to vp_env
  storage: fix build
  core: re-export borsh
  move account related code from namada_storage to namada_account
  trans_token: fix build
  move ERC20 address constructors back to core
  core/types/internal: remove unsued import
  move core::types::vote_extensions into namada_vote_ext crate
  move core MembershipProof into merkle_tree crate
  move EvalVp from core into tx::data::eval_vp
  core/types/key: remove unused error case
  move state::traits hasher into core::types::hash
  namada_account: take account keys storage from namada_core::types::key
  namada_account: fix imports, update docstring
  add namada_account crate from namada_core::types::account
  move core::types::internal::tx into namada_state::tx_queue
  tx_env: update imports
  add namada_tx_env out of core::ledger::tx_env mod
  add namada_storage crate out of core::ledger::storage_api
  core: make vp_env crate out of ledger::vp_env mod
  core: move types::transaction mods into namada_tx::data
  update lock
  core: move proto and into namada_tx crate
  gas: fix imports
  core: move ledger::gas into new namada_gas crate
  ...
* origin/tomas/crates-dir:
  `mv crates/shared crates/namada` and update paths
  git: ignore the old proto artifact
  changelog: add #2386
  fix relative paths
  move most sub-crates into crates dir
* origin/grarco/comet-timestamp:
  Adds block timestamp in unit and integration tests
  Changelog #2383
  Expect a proposed block to always carry a valid timestamp
* origin/grarco/gas-sentinel-fix:
  Changelog #2395
  Sets gas sentinel in `ibc_tx_charge_gas`
* origin/yuji/fix-e2e-pgf-ibc:
  add change log
  add wait before balance check
* origin/grarco/fee-rafactor:
  Changelog #2382
  Moves validation methods to functions
  Refactors `wrapper_fee_check`
* origin/fraccaman/sdk-rpc-queries:
  added pgf parameters rpc
  added proposal result query to sdk, refactor
  added total supply router/rpc method
@tzemanovic tzemanovic changed the title Draft Draft 0.30.1 Jan 17, 2024
@tzemanovic tzemanovic closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants