-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft #2371 check #2387
Closed
Closed
Draft #2371 check #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* grarco/masp-vp-expiration: Changelog #2375 MASP vp validates tx expiration
* grarco/light-sdk-deps: Changelog #2372 Adds light sdk to Makefile Cleans up light sdk dependencies
* fraccaman+grarco/governance-tests: Changelog #2330 Fixes broken governance test Removes duplicated proposal vote enum Removes useless `VoteType` enum. Misc refactors Returns early if proposal voter doesn't have a stake Improves governance messages Adds `query_proposal_votes` Improves formatting of `ProposalResult`
* tiago+gian/required-proposal-id: Changelog #2365 `prepare_proposal_data` test helper requires proposal id Fix docstr errs Make `proposal_id` a required field in gov proposals
* grarco/governance-cleanup: Changelog #2377 Shared function for governance total voted power Nit renames variable in `ProposalResult` display
* brent/fix-bond-amount: changelog: add #2374 fix `bond_amount`
* origin/grarco/remove-masp-key: Changelog #2376 Removes the hardcoded masp sentinel key
* origin/grarco/masp-storage-optimization: [feat] Refactoring extraction of shielded parts of txs to be more dry Shared function for shielded actions retrieval Reverts trait bound on `Height` for `block_results` endpoint Uses `masp_pin_tx_key` helper where possible Changelog #2363 `compute_pinned_balance` supports pinned masp over ibc transactions Improves masp over ibc tx fetching in client Refactors wrapper tx args for execution Cleans up sdk masp file Moves block query logic of integration tests in `block` Refactors and fixes benchmarks Refactors tx caching in `ShieldedContext` Fixes integration tests Updates masp queries to avoid the need for an indexer Fixes integration tests Fetches masp txs from blocks Adds a new tx event attribute to index masp txs Updates keys check in masp vp Updates masp storage keys helper functions Removes masp tx writing of lookup data to storage
* origin/murisi/masp-fixes: Added changelog entry. Unified the functions that construct AssetType to ensure encoding consistency. Fixed the printing of shielded balance for specific token across users. Improve the handling of trace amounts during conversions of assets to older epochs. Shielded balance printing now includes trace assets. Allow notes containing older epochs to be spent. Use a note only if theres a shortfall and it would help close it. Stop creating redundant transaction descriptors. Redefined MaspAmount using the ValueSum type from the MASP crate. Removed now redundant operations on MaspAmount. Reduce the amount of decoding and encoding of AssetTypes. Refactored the validation of shielded transaction transparent outputs. Now avoid assuming that transparent outputs are ordered. Avoid assuming that there must be transparent outputs. Ensure that total of transparent output values match the containing transaction. Increased the validation of transparent inputs to be similar to that of transparent outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI check for #2371