Tx expiration updates #2315
Merged
Tx expiration updates #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grarco
force-pushed
the
grarco/tx-expiration-update
branch
from
6d31c71 to
bb9d013
Compare
tzemanovic
approved these changes
Dec 22, 2023
Closed
grarco
added a commit
that referenced
this pull request
Dec 27, 2023
grarco
added a commit
that referenced
this pull request
Dec 27, 2023
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/grarco/tx-expiration-update: Updates masp fixtures Changelog #2315 Updates masp tx generation to include expiration MASP vp expiration always required MASP vp checks transaction's expiration Updates TODO for disposable signer Validates tx expiration again for decrypted tx
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Addresses #1373 (comment).
Updates the expiration check on transactions to be done again on decrypted tx to catch txs that failed in between the two blocks execution process (especially useful in case of a chain halt + rollback).
Updates the MASP Vp to check expiration on the masp
Transactionobject and modifies the SDK to derive a sane value for this expiration.Indicate on which release or other PRs this topic is based on
Commit 74d412e of
base(v0.28.1)Checklist before merging to
draft