Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for genesis time #2310

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Wait for genesis time #2310

merged 5 commits into from
Dec 29, 2023

Conversation

batconjurer
Copy link
Member

@batconjurer batconjurer commented Dec 19, 2023

Describe your changes

Make the ledger wait for genesis before starting up any processes

Indicate on which release or other PRs this topic is based on

v0.28

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of potential issues

apps/src/lib/node/ledger/mod.rs Outdated Show resolved Hide resolved
apps/src/lib/node/ledger/mod.rs Outdated Show resolved Hide resolved
@batconjurer batconjurer requested a review from sug0 December 19, 2023 14:28
Fraccaman pushed a commit that referenced this pull request Dec 27, 2023
* origin/bat/feat/wait-for-genesis:
  [fix]: Don't spawn another async task to shutdown while waiting for genesis.
  Addressing review comments
  [fix]: Fixed english
  changelog
  [fix]: Make the ledger wait for genesis before starting up any processes
@Fraccaman Fraccaman mentioned this pull request Dec 27, 2023
Fraccaman pushed a commit that referenced this pull request Dec 27, 2023
* origin/bat/feat/wait-for-genesis:
  [fix]: Don't spawn another async task to shutdown while waiting for genesis.
  Addressing review comments
  [fix]: Fixed english
  changelog
  [fix]: Make the ledger wait for genesis before starting up any processes
brentstone added a commit that referenced this pull request Dec 29, 2023
* origin/bat/feat/wait-for-genesis:
  [fix]: Don't spawn another async task to shutdown while waiting for genesis.
  Addressing review comments
  [fix]: Fixed english
  changelog
  [fix]: Make the ledger wait for genesis before starting up any processes
@brentstone brentstone merged commit 605f5c3 into main Dec 29, 2023
13 of 15 checks passed
@brentstone brentstone deleted the bat/feat/wait-for-genesis branch December 29, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants