-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for genesis time #2310
Merged
Merged
Wait for genesis time #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of potential issues
sug0
approved these changes
Dec 20, 2023
Fraccaman
pushed a commit
that referenced
this pull request
Dec 27, 2023
* origin/bat/feat/wait-for-genesis: [fix]: Don't spawn another async task to shutdown while waiting for genesis. Addressing review comments [fix]: Fixed english changelog [fix]: Make the ledger wait for genesis before starting up any processes
Closed
Fraccaman
pushed a commit
that referenced
this pull request
Dec 27, 2023
* origin/bat/feat/wait-for-genesis: [fix]: Don't spawn another async task to shutdown while waiting for genesis. Addressing review comments [fix]: Fixed english changelog [fix]: Make the ledger wait for genesis before starting up any processes
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/bat/feat/wait-for-genesis: [fix]: Don't spawn another async task to shutdown while waiting for genesis. Addressing review comments [fix]: Fixed english changelog [fix]: Make the ledger wait for genesis before starting up any processes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Make the ledger wait for genesis before starting up any processes
Indicate on which release or other PRs this topic is based on
v0.28
Checklist before merging to
draft