Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Murisi/strategy constructors #2259

Merged
merged 17 commits into from
Dec 29, 2023
Merged

Murisi/strategy constructors #2259

merged 17 commits into from
Dec 29, 2023

Conversation

murisi
Copy link
Collaborator

@murisi murisi commented Dec 9, 2023 •
edited
Loading

Describe your changes

Updated the test vector generation code to make it easier to produce complete test vectors. More specifically, the changes are as follows:

  • Test vector generation is now done offline using a Cargo [[example]] so that those needing them do not need to start a server to produce them
  • Vector generation is now randomly produced with proptest strategies in order to more comprehensively cover the full domain of transactions
    • This approach has the additional benefit that these strategies can also be reused in other proptest tests
  • Vector generation is now done in Rust in order to take advantage of Rust's type-checking and to ensure that the code is kept up to date
  • The old approach to generating test vectors using shell scripts and hooks in the transaction generation and signing process have been removed as they are now redundant

Indicate on which release or other PRs this topic is based on

#2257

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

murisi added 15 commits December 4, 2023 17:55
@murisi
Now denominate the fee amount in wrapper headers.
fd07f6b
@murisi
Removed to_ledger_vectors dependency on Namada client.
32ec88c
@murisi
Protocol now ensures that a DenominatedAmounts denom is correct. Adde…
439fec1 
…d checked arithmetic operations to DenominatedAmount to catch mistakes.
@murisi
Dont introduce denominations in the bridge pool transaction WASM.
f551e29
@murisi
Fixed the redaction of MASP amounts and ensured that correct token ty…
e8cb0c1 
…pe is attached. Integration tests now work.
@murisi
Fixed the formatting of update account in the test vectors.
8b28d27
@murisi
Added a unit test for denominated arithmetic.
ef1894c
@murisi
Add test vector printers for bridge pool transfers, resign steward, u…
41acfb9 
…pdate steward commission, and redelegate.
@murisi
Added changelog entry.
ff27346
@murisi
Merge branch 'base' into murisi/denominated-fee-amount-on-0.28.0
a723d00
@murisi
Added proptest strategies for generating transactions.
2e367ed
@murisi
Added a binary to automatically generate test vectors.
4ca6922
@murisi
Removed generate_test_vector and the test vector shell script since t…
3833c7e 
…hey have been made redundant by the generate_txs example.
@murisi
Added a README to explain the new examples directory.
ebcf85a
@murisi
Added a changelog entry.
88ab883
@murisi murisi requested review from tzemanovic and sug0 December 9, 2023 22:15
@murisi murisi marked this pull request as ready for review December 9, 2023 22:15
@murisi murisi mentioned this pull request Dec 9, 2023
Closed
@murisi murisi requested a review from karbyshev December 9, 2023 22:28
sug0
sug0 reviewed Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments

core/src/ledger/ibc/mod.rs Show resolved Hide resolved
core/src/types/eth_bridge_pool.rs Outdated Show resolved Hide resolved
core/src/types/eth_bridge_pool.rs Outdated Show resolved Hide resolved
core/src/types/hash.rs Outdated Show resolved Hide resolved
tzemanovic
tzemanovic reviewed Dec 11, 2023
View reviewed changes
core/src/types/token.rs Outdated Show resolved Hide resolved
tzemanovic
tzemanovic previously approved these changes Dec 11, 2023
View reviewed changes
@sug0 sug0 self-requested a review December 12, 2023 18:31
Fraccaman pushed a commit that referenced this pull request Dec 14, 2023
Merge branch murisi/strategy-constructors' (#2259)
57db046 
* origin/murisi/strategy-constructors:
  renaming and restructuring testing modules for consistency
  testing: use the appropriate address generators for address type
  Added a changelog entry.
  Added a README to explain the new examples directory.
  Removed generate_test_vector and the test vector shell script since they have been made redundant by the generate_txs example.
  Added a binary to automatically generate test vectors.
  Added proptest strategies for generating transactions.
brentstone added a commit that referenced this pull request Dec 29, 2023
@brentstone
Merge branch 'murisi/strategy-constructors' (#2259)
446b07d 
* origin/murisi/strategy-constructors:
  renaming and restructuring testing modules for consistency
  testing: use the appropriate address generators for address type
  Added a changelog entry.
  Added a README to explain the new examples directory.
  Removed generate_test_vector and the test vector shell script since they have been made redundant by the generate_txs example.
  Added a binary to automatically generate test vectors.
  Added proptest strategies for generating transactions.
@brentstone brentstone merged commit 7294e00 into main Dec 29, 2023
13 of 14 checks passed
@brentstone brentstone deleted the murisi/strategy-constructors branch December 29, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic tzemanovic left review comments

@sug0 sug0 sug0 approved these changes

@karbyshev karbyshev Awaiting requested review from karbyshev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murisi @tzemanovic @sug0 @brentstone