-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client command to dry run genesis files #2255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tzemanovic
previously approved these changes
Dec 8, 2023
Closed
sug0
reviewed
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of comments
sug0
previously approved these changes
Dec 11, 2023
I noticed on merging there were artifacts from |
tzemanovic
added a commit
that referenced
this pull request
Dec 14, 2023
* bat/feat/dry-run: test: use tempdirs for genesis artifacts [fix]: Addressing review comments [chore]: Add changelog [feat]: Added a cli command to dry run init-chain with genesis files and report all errors found
tzemanovic
added a commit
that referenced
this pull request
Dec 14, 2023
tzemanovic
added a commit
that referenced
this pull request
Dec 15, 2023
tzemanovic
added a commit
that referenced
this pull request
Dec 15, 2023
This reverts commit a7d298f.
tzemanovic
added a commit
that referenced
this pull request
Dec 15, 2023
This reverts commit 9eccda4.
tzemanovic
added a commit
that referenced
this pull request
Dec 15, 2023
tzemanovic
force-pushed
the
bat/feat/dry-run
branch
from
December 22, 2023 09:12
27bd6fb
to
3f85b40
Compare
tzemanovic
added a commit
that referenced
this pull request
Dec 22, 2023
* bat/feat/dry-run: test: use tempdirs for genesis artifacts [fix]: Addressing review comments [chore]: Add changelog [feat]: Added a cli command to dry run init-chain with genesis files and report all errors found
tzemanovic
added a commit
that referenced
this pull request
Dec 22, 2023
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/bat/feat/dry-run: test: use tempdirs for genesis artifacts [fix]: Addressing review comments [chore]: Add changelog [feat]: Added a cli command to dry run init-chain with genesis files and report all errors found
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new client command has been added that takes a set of pre-genesis template files, validates them, and runs them through
init_chain
. All errors are collected into a report.This also closes #761
Checklist before merging to
draft