Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client command to dry run genesis files #2255

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Conversation

batconjurer
Copy link
Member

A new client command has been added that takes a set of pre-genesis template files, validates them, and runs them through init_chain. All errors are collected into a report.

This also closes #761

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

tzemanovic
tzemanovic previously approved these changes Dec 8, 2023
@tzemanovic tzemanovic mentioned this pull request Dec 8, 2023
Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments

apps/src/lib/cli.rs Outdated Show resolved Hide resolved
apps/src/lib/cli/client.rs Outdated Show resolved Hide resolved
apps/src/lib/node/ledger/mod.rs Outdated Show resolved Hide resolved
apps/src/lib/node/ledger/shell/init_chain.rs Show resolved Hide resolved
apps/src/lib/node/ledger/shell/init_chain.rs Show resolved Hide resolved
apps/src/lib/node/ledger/shell/init_chain.rs Show resolved Hide resolved
apps/src/lib/node/ledger/shell/init_chain.rs Show resolved Hide resolved
sug0
sug0 previously approved these changes Dec 11, 2023
@tzemanovic
Copy link
Member

I noticed on merging there were artifacts from make test-unit - I fixed it in 27bd6fb

tzemanovic added a commit that referenced this pull request Dec 14, 2023
* bat/feat/dry-run:
  test: use tempdirs for genesis artifacts
  [fix]: Addressing review comments
  [chore]: Add changelog
  [feat]: Added a cli command to dry run init-chain with genesis files and report all errors found
tzemanovic added a commit that referenced this pull request Dec 15, 2023
tzemanovic added a commit that referenced this pull request Dec 15, 2023
tzemanovic added a commit that referenced this pull request Dec 15, 2023
This reverts commit 06af3ae, reversing
changes made to 508185d.
tzemanovic added a commit that referenced this pull request Dec 22, 2023
* bat/feat/dry-run:
  test: use tempdirs for genesis artifacts
  [fix]: Addressing review comments
  [chore]: Add changelog
  [feat]: Added a cli command to dry run init-chain with genesis files and report all errors found
brentstone added a commit that referenced this pull request Dec 29, 2023
* origin/bat/feat/dry-run:
  test: use tempdirs for genesis artifacts
  [fix]: Addressing review comments
  [chore]: Add changelog
  [feat]: Added a cli command to dry run init-chain with genesis files and report all errors found
@brentstone brentstone merged commit 9e45209 into main Dec 29, 2023
14 of 15 checks passed
@brentstone brentstone deleted the bat/feat/dry-run branch December 29, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validators should check that they can compile wasm at startup.
4 participants