Support Send trait in the SDK #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
previously approved these changes
Nov 30, 2023
tzemanovic
approved these changes
Dec 6, 2023
sug0
approved these changes
Dec 7, 2023
Comment on lines
+71
to
+78
| #[cfg(not(feature = "async-send"))] | ||
| pub trait MaybeSync {} | ||
| #[cfg(not(feature = "async-send"))] | ||
| impl<T> MaybeSync for T where T: ?Sized {} | ||
| #[cfg(not(feature = "async-send"))] | ||
| pub trait MaybeSend {} | ||
| #[cfg(not(feature = "async-send"))] | ||
| impl<T> MaybeSend for T where T: ?Sized {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added
Sendtrait support to the SDK. More specifically, made the following changes:Sendtrait support ofIo,Namada,FsShieldedUtils,NamadaImpl,NullIo, andStdIoonasync-sendflagMaybeSyncandMaybeSendtraits that are eitherSyncandSendor neither depending on theasync-sendflagNamadatrait:Io,WalletUtils,ShieldedUtils, andIoledger-namada-rsdependency since the previous revision used is now missing and hence causing CI to failSee the namada-faucet branch https://github.com/heliaxdev/namada-faucet/tree/murisi/try-send-trait for a demonstration for how the Send trait is used.
Indicate on which release or other PRs this topic is based on
#2225
Checklist before merging to
draft