Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade ledger-namada version #2223

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

tzemanovic
Copy link
Member

Describe your changes

The commit we used is from a branch that's been yanked, we should be using this one instead.

Indicate on which release or other PRs this topic is based on

v0.27.0

Checklist before merging to draft

  • [ ] I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic requested a review from murisi November 28, 2023 15:37
Copy link
Collaborator

@murisi murisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use ledger-namada-rs = { git = "https://github.com/Zondax/ledger-namada", rev = "4fd882b84af7c93a1332c32a4e3d705fd63f09ab" } instead please?

@tzemanovic
Copy link
Member Author

Could we use ledger-namada-rs = { git = "https://github.com/Zondax/ledger-namada", rev = "4fd882b84af7c93a1332c32a4e3d705fd63f09ab" } instead please?

absolutely, one sec

@tzemanovic tzemanovic force-pushed the tomas/namada-ledger-ver branch from 3b8f7e5 to dacad96 Compare November 28, 2023 17:05
@tzemanovic tzemanovic marked this pull request as ready for review November 28, 2023 17:06
tzemanovic added a commit that referenced this pull request Nov 29, 2023
* origin/tomas/namada-ledger-ver:
  deps: upgrade ledger-namada version
This was referenced Nov 29, 2023
@tzemanovic tzemanovic merged commit 3d1f452 into main Dec 7, 2023
14 checks passed
@tzemanovic tzemanovic deleted the tomas/namada-ledger-ver branch December 7, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants