Update consensus key change #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
brent/upgrade-consensus-key-change
branch
from
bff9734 to
0e5e59f
Compare
tzemanovic
added a commit
that referenced
this pull request
Dec 8, 2023
tzemanovic
previously approved these changes
Dec 8, 2023
Closed
brentstone
commented
Dec 8, 2023
brentstone
pushed a commit
that referenced
this pull request
Dec 12, 2023
Fraccaman
pushed a commit
that referenced
this pull request
Dec 13, 2023
* origin/brent/upgrade-consensus-key-change: changelog: add #2218 client/tx: tidy up change-consensus-key github/workflows: add e2e test test/e2e: make `Who` copy-able test/e2e/ledger: finish consensus key change test need `unsafe-dont-encrypt` arg for testing fix bug WIP
2 tasks
tzemanovic
approved these changes
Dec 14, 2023
|
fixed the issue in benches 1c4f085 - the tx needed the extra sig with the new consensus key |
brentstone
force-pushed
the
brent/upgrade-consensus-key-change
branch
from
1c4f085 to
dd28da1
Compare
brentstone
added a commit
that referenced
this pull request
Dec 17, 2023
* brent/upgrade-consensus-key-change: benches/tx: fix change_consensus_key by adding the extra req sig changelog: add #2218 client/tx: tidy up change-consensus-key github/workflows: add e2e test test/e2e: make `Who` copy-able test/e2e/ledger: finish consensus key change test need `unsafe-dont-encrypt` arg for testing fix bug WIP
brentstone
added a commit
that referenced
this pull request
Dec 18, 2023
* brent/upgrade-consensus-key-change: benches/tx: fix change_consensus_key by adding the extra req sig changelog: add #2218 client/tx: tidy up change-consensus-key github/workflows: add e2e test test/e2e: make `Who` copy-able test/e2e/ledger: finish consensus key change test need `unsafe-dont-encrypt` arg for testing fix bug WIP
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/brent/upgrade-consensus-key-change: benches/tx: fix change_consensus_key by adding the extra req sig changelog: add #2218 client/tx: tidy up change-consensus-key github/workflows: add e2e test test/e2e: make `Who` copy-able test/e2e/ledger: finish consensus key change test need `unsafe-dont-encrypt` arg for testing fix bug WIP
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add an e2e test and require to sign the tx with the new consensus key.
Indicate on which release or other PRs this topic is based on
v0.28.1
Checklist before merging to
draft