Prune Merkle tree of bridge pool #2206
Conversation
| let nonce = Uint::try_from_slice(&bytes) | ||
| .map_err(Error::BorshCodingError)?; | ||
| if nonce < current_nonce { | ||
| break; |
There was a problem hiding this comment.
Isn't this returning at the first epoch with an invalid nonce instead of the last one matching the current nonce?
There was a problem hiding this comment.
The nonce was incremented to the current one during the epoch though the epoch has the invalid nonce at the starting height. The Merkle tree at the epoch starting would be required to rebuild one at a height (after the nonce was incremented) during the epoch. So, the Merkle tree in the epoch should have a valid nonce.
There is a corner case; the nonce was incremented at the same height when the epoch was updated. However, the Merkle tree snapshot would be pruned eventually.
| storage.write(&bp_nonce_key, bytes).unwrap(); | ||
|
|
||
| let bytes = types::encode(&Uint::default()); | ||
| storage.write(&bp_nonce_key, bytes).unwrap(); |
There was a problem hiding this comment.
Do we need this second write since we've just written the same key?
* origin/yuji/prune-bp-merkle-tree: remove unneeded write add test and changelog prune merkle trees of bridge pool
Describe your changes
closes #2110
Indicate on which release or other PRs this topic is based on
0.27.0Checklist before merging to
draft