Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce merkle tree snapshots #2050

Merged
merged 7 commits into from
Nov 11, 2023
Merged

Reduce merkle tree snapshots #2050

merged 7 commits into from
Nov 11, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Oct 25, 2023 •
edited
Loading

Describe your changes

closes #2043

Indicate on which release or other PRs this topic is based on

v0.25.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 marked this pull request as ready for review October 26, 2023 18:39
@yito88 yito88 requested review from sug0 and tzemanovic October 26, 2023 18:39
@yito88 yito88 added the storage label Oct 26, 2023
sug0
sug0 requested changes Oct 27, 2023
View reviewed changes
apps/src/lib/node/ledger/storage/rocksdb.rs Outdated Show resolved Hide resolved
apps/src/lib/node/ledger/storage/rocksdb.rs Outdated Show resolved Hide resolved
core/src/ledger/storage/merkle_tree.rs Outdated Show resolved Hide resolved
core/src/ledger/storage/merkle_tree.rs Outdated Show resolved Hide resolved
core/src/ledger/storage/mod.rs Show resolved Hide resolved
ethereum_bridge/src/test_utils.rs Outdated Show resolved Hide resolved
@Fraccaman Fraccaman mentioned this pull request Oct 27, 2023
Closed
@yito88 yito88 requested a review from sug0 October 30, 2023 15:13
@yito88 yito88 requested a review from grarco November 6, 2023 17:23
@brentstone brentstone mentioned this pull request Nov 7, 2023
Closed
This was referenced Nov 7, 2023
Closed
Closed
yito88 added a commit that referenced this pull request Nov 8, 2023
@yito88
Merge branch 'yuji/reduce_merkle_stores' (#2050)
ce62c6d
@adrianbrink adrianbrink merged commit c96c6a9 into main Nov 11, 2023
13 of 14 checks passed
@adrianbrink adrianbrink deleted the yuji/reduce_merkle_stores branch November 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grarco grarco grarco approved these changes

@sug0 sug0 sug0 approved these changes

@tzemanovic tzemanovic Awaiting requested review from tzemanovic

Assignees
No one assigned
Labels
storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store only essential Merkle tree snapshots
5 participants
@yito88 @sug0 @grarco @adrianbrink @brentstone