Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: turn off rocksdb jemalloc on windows #2047

Merged
merged 2 commits into from
Oct 30, 2023
Merged

apps: turn off rocksdb jemalloc on windows #2047

merged 2 commits into from
Oct 30, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Oct 25, 2023

Describe your changes

rocksdb (tikv-)jemalloc is not supported on windows (https://github.com/tikv/jemallocator#platform-support)

Indicate on which release or other PRs this topic is based on

0.25.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic requested a review from Fraccaman October 25, 2023 06:23
@tzemanovic tzemanovic marked this pull request as ready for review October 25, 2023 06:25
@Fraccaman
Copy link
Member

spawn devnet help

@namadabot
Copy link

namadabot bot commented Oct 26, 2023

@Fraccaman, use the following template to spawn a devnet:

Field Value
command spawn devnet
template_name string (mandatory)
retention_period date YYYY-MM-DDT00:00:00Z (mandatory)
epochs_per_year number (default to 60000)
block_time number (default to 10)
total_validators number (default to 3)

@Fraccaman
Copy link
Member

Field Value
command spawn devnet
template_name 0.24.0
retention_period 2023-10-28T12:00:00Z

1 similar comment
@Fraccaman
Copy link
Member

Field Value
command spawn devnet
template_name 0.24.0
retention_period 2023-10-28T12:00:00Z

@Fraccaman Fraccaman mentioned this pull request Oct 27, 2023
Fraccaman added a commit that referenced this pull request Oct 30, 2023
* origin/tomas/win-build:
  changelog: add #2047
  apps: turn off rocksdb jemalloc on windows
@brentstone brentstone merged commit c0bf7c4 into main Oct 30, 2023
14 checks passed
@brentstone brentstone deleted the tomas/win-build branch October 30, 2023 23:04
batconjurer pushed a commit that referenced this pull request Nov 2, 2023
batconjurer added a commit that referenced this pull request Nov 2, 2023
…o bat/feat/new-genesis-CI

* 'bat/feat/new-genesis-CI' of github.com:anoma/namada:
  fix fmt
  fix `make check-crates`
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
  Namada 0.24.1
  test: remove dead multitoken_tests
  remove vp/tx cache at startup
  [ci skip] specifiy aws region
  improve sdk
  added changelog
  wasm server download via env
  changelog: add #2047
  apps: turn off rocksdb jemalloc on windows
cwgoes added a commit that referenced this pull request Nov 5, 2023
* origin/bat/feat/new-genesis:
  wallet: don't crash when no wallet
  make: separate integration tests from units coverage
  genesis: rm dbg!s
  fix integration tests shell initialization
  deps: remove now unused file-serve
  allow to join-network with archive in a dir
  genesis: fix import warn
  test+bench: use `defaults::validator_keypair` for genesis validator-0
  rename `HexString::to_bytes` to `parse` and remove other unused methods
  bench: fix txs benches by writing a chain genesis config to FS
  make: skip pos_state_machine_test in unit tests
  genesis: use the default addresses for tests and benches
  bench: fix voting epochs to correspond to PoS params
  apps/genesis: change root dir detection
  remove the rest of the "dev" feature usages
  [fix]: Fixed benchmarks, e2e test ci scripts, masp conversion persistence issue, and formatting
  [fix]: Formatting
  [fix]: Fixed signer decoding for ibc
  [fix]: Linting
  [fix] Regenerated MASP integration test proofs
  merging in upstream changes from feature branch
  fix `make check-crates`
  [fix]: Compiling now. Tests need fixing
  Namada 0.24.1
  test: remove dead multitoken_tests
  changelog: add #2047
  apps: turn off rocksdb jemalloc on windows
  remove vp/tx cache at startup
  improve sdk
  added changelog
  wasm server download via env
  [ci skip] specifiy aws region
  [fix]: Fix integration tests
  fix fmt
  fix `make check-crates`
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
cwgoes added a commit that referenced this pull request Nov 5, 2023
* origin/bat/feat/new-genesis:
  make: fix test-coverage
  wallet: don't crash when no wallet
  make: separate integration tests from units coverage
  genesis: rm dbg!s
  fix integration tests shell initialization
  deps: remove now unused file-serve
  allow to join-network with archive in a dir
  genesis: fix import warn
  test+bench: use `defaults::validator_keypair` for genesis validator-0
  rename `HexString::to_bytes` to `parse` and remove other unused methods
  bench: fix txs benches by writing a chain genesis config to FS
  make: skip pos_state_machine_test in unit tests
  genesis: use the default addresses for tests and benches
  bench: fix voting epochs to correspond to PoS params
  apps/genesis: change root dir detection
  remove the rest of the "dev" feature usages
  [fix]: Fixed benchmarks, e2e test ci scripts, masp conversion persistence issue, and formatting
  [fix]: Formatting
  [fix]: Fixed signer decoding for ibc
  [fix]: Linting
  [fix] Regenerated MASP integration test proofs
  merging in upstream changes from feature branch
  fix `make check-crates`
  [fix]: Compiling now. Tests need fixing
  Namada 0.24.1
  test: remove dead multitoken_tests
  changelog: add #2047
  apps: turn off rocksdb jemalloc on windows
  remove vp/tx cache at startup
  improve sdk
  added changelog
  wasm server download via env
  [ci skip] specifiy aws region
  [fix]: Fix integration tests
  fix fmt
  fix `make check-crates`
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
cwgoes added a commit that referenced this pull request Nov 5, 2023
* origin/bat/feat/new-genesis:
  changelog: add #2088
  make: fix test-coverage
  wallet: don't crash when no wallet
  make: separate integration tests from units coverage
  genesis: rm dbg!s
  fix integration tests shell initialization
  deps: remove now unused file-serve
  allow to join-network with archive in a dir
  genesis: fix import warn
  test+bench: use `defaults::validator_keypair` for genesis validator-0
  rename `HexString::to_bytes` to `parse` and remove other unused methods
  bench: fix txs benches by writing a chain genesis config to FS
  make: skip pos_state_machine_test in unit tests
  genesis: use the default addresses for tests and benches
  bench: fix voting epochs to correspond to PoS params
  apps/genesis: change root dir detection
  remove the rest of the "dev" feature usages
  [fix]: Fixed benchmarks, e2e test ci scripts, masp conversion persistence issue, and formatting
  [fix]: Formatting
  [fix]: Fixed signer decoding for ibc
  [fix]: Linting
  [fix] Regenerated MASP integration test proofs
  merging in upstream changes from feature branch
  fix `make check-crates`
  [fix]: Compiling now. Tests need fixing
  Namada 0.24.1
  test: remove dead multitoken_tests
  changelog: add #2047
  apps: turn off rocksdb jemalloc on windows
  remove vp/tx cache at startup
  improve sdk
  added changelog
  wasm server download via env
  [ci skip] specifiy aws region
  [fix]: Fix integration tests
  fix fmt
  fix `make check-crates`
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
@tzemanovic tzemanovic mentioned this pull request Nov 5, 2023
2 tasks
brentstone pushed a commit that referenced this pull request Nov 11, 2023
brentstone added a commit that referenced this pull request Nov 11, 2023
* origin/tomas/win-build:
  changelog: add #2047
  apps: turn off rocksdb jemalloc on windows
brentstone pushed a commit that referenced this pull request Nov 11, 2023
brentstone pushed a commit that referenced this pull request Nov 11, 2023
…o bat/feat/new-genesis-CI

* 'bat/feat/new-genesis-CI' of github.com:anoma/namada:
  fix fmt
  fix `make check-crates`
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
  Namada 0.24.1
  test: remove dead multitoken_tests
  remove vp/tx cache at startup
  [ci skip] specifiy aws region
  improve sdk
  added changelog
  wasm server download via env
  changelog: add #2047
  apps: turn off rocksdb jemalloc on windows
brentstone pushed a commit that referenced this pull request Nov 11, 2023
* origin/bat/feat/new-genesis:
  changelog: add #2088
  make: fix test-coverage
  wallet: don't crash when no wallet
  make: separate integration tests from units coverage
  genesis: rm dbg!s
  fix integration tests shell initialization
  deps: remove now unused file-serve
  allow to join-network with archive in a dir
  genesis: fix import warn
  test+bench: use `defaults::validator_keypair` for genesis validator-0
  rename `HexString::to_bytes` to `parse` and remove other unused methods
  bench: fix txs benches by writing a chain genesis config to FS
  make: skip pos_state_machine_test in unit tests
  genesis: use the default addresses for tests and benches
  bench: fix voting epochs to correspond to PoS params
  apps/genesis: change root dir detection
  remove the rest of the "dev" feature usages
  [fix]: Fixed benchmarks, e2e test ci scripts, masp conversion persistence issue, and formatting
  [fix]: Formatting
  [fix]: Fixed signer decoding for ibc
  [fix]: Linting
  [fix] Regenerated MASP integration test proofs
  merging in upstream changes from feature branch
  fix `make check-crates`
  [fix]: Compiling now. Tests need fixing
  Namada 0.24.1
  test: remove dead multitoken_tests
  changelog: add #2047
  apps: turn off rocksdb jemalloc on windows
  remove vp/tx cache at startup
  improve sdk
  added changelog
  wasm server download via env
  [ci skip] specifiy aws region
  [fix]: Fix integration tests
  fix fmt
  fix `make check-crates`
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
  More fixes
  [fix]: Fixed unit tests
  [fix]: Compiling now. Tests need fixing
  fixup! [feat] Re-implementing new genesis flow in v0.24
  [feat] Re-implementing new genesis flow in v0.24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants