Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the start block height of the first epoch #1993

Merged
merged 8 commits into from
Dec 7, 2023
Merged

fix the start block height of the first epoch #1993

merged 8 commits into from
Dec 7, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Oct 17, 2023 •
edited
Loading

Describe your changes

closes #648, close #454

Indicate on which release or other PRs this topic is based on

0.23

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

tzemanovic added a commit that referenced this pull request Oct 17, 2023
@tzemanovic
changelog: add #1993
3c04705
@tzemanovic tzemanovic requested a review from yito88 October 17, 2023 06:29
@tzemanovic tzemanovic marked this pull request as ready for review October 17, 2023 06:29
@tzemanovic tzemanovic marked this pull request as draft October 17, 2023 07:07
tzemanovic added a commit that referenced this pull request Oct 17, 2023
@tzemanovic
changelog: add #1993
0f445ae
@tzemanovic tzemanovic force-pushed the tomas/fst-epoch-start-height branch from 3c04705 to 0f445ae Compare October 17, 2023 07:20
@tzemanovic tzemanovic marked this pull request as ready for review October 17, 2023 07:20
sug0
sug0 reviewed Oct 17, 2023
View reviewed changes
core/src/types/storage.rs Outdated Show resolved Hide resolved
core/src/types/storage.rs Outdated Show resolved Hide resolved
@tzemanovic tzemanovic mentioned this pull request Oct 17, 2023
Closed
2 tasks
@tzemanovic tzemanovic force-pushed the tomas/fst-epoch-start-height branch from d05284e to 3ea8305 Compare October 19, 2023 05:45
@tzemanovic
Copy link
Member Author

I squashed the fixup commits in the last f-push (no diff)

@tzemanovic tzemanovic mentioned this pull request Oct 23, 2023
Closed
@Fraccaman Fraccaman mentioned this pull request Oct 27, 2023
Closed
@tzemanovic tzemanovic mentioned this pull request Nov 22, 2023
Closed
tzemanovic added a commit that referenced this pull request Nov 27, 2023
@tzemanovic
Merge branch 'tomas/fst-epoch-start-height' (#1993)
83d5f22 
* origin/tomas/fst-epoch-start-height:
  changelog: add #1993
  test/core/storage: fix pred epochs & heights test
  test/app/ledger: fix merkle tree pruning test
  apps/shell/finalize_block: remove first epoch workaround
  core/storage/epochs: Change pred `Epochs` default to be empty
  core/storage: add `BlockHeight::first` and `sentinel`
  core/storage: set the initial height from genesis
  core/storage: change the default start height of first epoch to 1
tzemanovic added a commit that referenced this pull request Nov 28, 2023
@tzemanovic
fixup! Merge branch 'tomas/fst-epoch-start-height' (#1993)
5a3af44
@tzemanovic tzemanovic merged commit 40ad3af into main Dec 7, 2023
@tzemanovic tzemanovic deleted the tomas/fst-epoch-start-height branch December 7, 2023 17:59
@tzemanovic tzemanovic mentioned this pull request Jan 9, 2024
Merged
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentstone brentstone brentstone left review comments

@sug0 sug0 sug0 left review comments

@yito88 yito88 yito88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatch in initial block heights at genesis storage.last_height should be an Option<BlockHeight>
4 participants
@tzemanovic @sug0 @yito88 @brentstone