Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves signatures verification gas in Signature #1954

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Sep 28, 2023

Describe your changes

Moves the gas accounting for the signature verification in the verify_signature method of Signature for higher resolution (i.e. being able to short circuit early in case of an out-of-gas event).

Indicate on which release or other PRs this topic is based on

v0.23.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@grarco grarco force-pushed the grarco/gas-in-sig-ver branch from 28f9583 to 6fba21a Compare September 28, 2023 11:37
@grarco grarco requested a review from murisi September 28, 2023 11:40
@grarco grarco marked this pull request as ready for review October 6, 2023 15:30
Copy link
Collaborator

@murisi murisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@Fraccaman Fraccaman mentioned this pull request Oct 16, 2023
grarco added a commit that referenced this pull request Oct 20, 2023
Fraccaman added a commit that referenced this pull request Oct 23, 2023
* origin/grarco/gas-in-sig-ver:
  changelog: add #1954
  Moves signatures verification gas in `Signature`
tzemanovic added a commit that referenced this pull request Oct 24, 2023
* origin/grarco/gas-in-sig-ver:
  changelog: add #1954
  Moves signatures verification gas in `Signature`
@tzemanovic tzemanovic mentioned this pull request Oct 24, 2023
@tzemanovic tzemanovic merged commit 6fba21a into main Oct 24, 2023
@tzemanovic tzemanovic deleted the grarco/gas-in-sig-ver branch October 24, 2023 11:26
brentstone pushed a commit that referenced this pull request Nov 11, 2023
* origin/grarco/gas-in-sig-ver:
  changelog: add #1954
  Moves signatures verification gas in `Signature`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants