Dummy PoW solution field for hardware wallet #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
approved these changes
Sep 28, 2023
Closed
murisi
force-pushed
the
murisi/pow-solution-fix
branch
from
36b2805 to
696c8be
Compare
murisi
added a commit
that referenced
this pull request
Oct 23, 2023
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/murisi/pow-solution-fix: Added changelog entry. Reintroduced a dummy field in order to achieve compatability with hardware wallet.
tzemanovic
added a commit
that referenced
this pull request
Oct 24, 2023
* origin/murisi/pow-solution-fix: Added changelog entry. Reintroduced a dummy field in order to achieve compatability with hardware wallet.
Merged
brentstone
pushed a commit
that referenced
this pull request
Nov 11, 2023
* origin/murisi/pow-solution-fix: Added changelog entry. Reintroduced a dummy field in order to achieve compatability with hardware wallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removal of the
pub pow_solution: Option<crate::ledger::testnet_pow::Solution>field fromWrapperTxbroke hardware wallet support for NamadaTxs. This PR reintroduces the field, albeit in a degenerate form.Indicate on which release or other PRs this topic is based on
v0.23.0 .
Checklist before merging to
draft