test benchmarks #1907
Merged
test benchmarks #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/test-benchmarks
branch
2 times, most recently
from
e676e68 to
9ac3548
Compare
tzemanovic
force-pushed
the
tomas/test-benchmarks
branch
from
83991e5 to
edfef5a
Compare
tzemanovic
force-pushed
the
tomas/test-benchmarks
branch
from
709cf5f to
ffb9278
Compare
|
I accidentally added a change that was meant to be for #1906 - force pushed to move it out |
grarco
approved these changes
Sep 22, 2023
tzemanovic
added a commit
that referenced
this pull request
Sep 25, 2023
* tomas/test-benchmarks: changelog: add #1907 benches: upgrade criterion.rs bench: fix ibc native_vp bench benches/process_wrapper: increase gas limit to make it pass benches: update tx signatures for multisig benches: fix gov to enter voting period before voting benches: fix epoch params in gov proposals shared/ledger/gov: add some logging to gov VP benches: add README.md benches: add tracing support CI/build-and-test: run `make test-benches` make: add `test-benches` recipe and add it to `test`
Closed
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/tomas/test-benchmarks: changelog: add #1907 benches: upgrade criterion.rs bench: fix ibc native_vp bench benches/process_wrapper: increase gas limit to make it pass benches: update tx signatures for multisig benches: fix gov to enter voting period before voting benches: fix epoch params in gov proposals shared/ledger/gov: add some logging to gov VP benches: add README.md benches: add tracing support CI/build-and-test: run `make test-benches` make: add `test-benches` recipe and add it to `test`
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Some benches are a bit stale and are failing. We should check that the benchmarks run successfully without performing the measurement or analysis in the CI.
Added
make test-benchesand a step in the CI to run these which won't be active until this PR is merged and because they are currently failing it's probably better so we're not affecting unrelated PRs.make test-benchespasses when this is being merged and released.Fixed failing benches:
Indicate on which release or other PRs this topic is based on
#1906 - first commit in this PR is 6f0033e
Checklist before merging to
draft