Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger test vector formatting changes #1888

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Ledger test vector formatting changes #1888

merged 2 commits into from
Oct 24, 2023

Conversation

karbyshev
Copy link
Contributor

@karbyshev karbyshev commented Sep 11, 2023 •
edited by murisi
Loading

Describe your changes

  • Updated the hardware wallet test vector generation script to be compatible with latest CLI
  • Updated the formatting of various test vectors and changed vector content where necessary
  • Made vote proposal respect the force flag and made unjail validator generate vector even if the action is not possible

Indicate on which release or other PRs this topic is based on

This is based on the previous branch aleks/ledger-test-vector-generator-fix-0.21.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@karbyshev karbyshev changed the title Ledger test vector formatting fixes for 0.21.1 Ledger test vector formatting changes for 0.22.0 Sep 11, 2023
@karbyshev karbyshev mentioned this pull request Sep 11, 2023
Closed
murisi added a commit that referenced this pull request Sep 22, 2023
@murisi
Merge branch 'aleks+murisi/ledger-test-vector-generator-fix-0.22.0' (#…
05e2d56 
…1888)
@murisi murisi force-pushed the aleks+murisi/ledger-test-vector-generator-fix-0.22.0 branch 2 times, most recently from 374fe3d to 8967c84 Compare September 27, 2023 09:02
@murisi murisi requested a review from tzemanovic September 27, 2023 09:10
@murisi murisi force-pushed the aleks+murisi/ledger-test-vector-generator-fix-0.22.0 branch from 8967c84 to 4d0d333 Compare September 27, 2023 11:48
@murisi murisi mentioned this pull request Oct 12, 2023
Closed
@murisi murisi changed the title Ledger test vector formatting changes for 0.22.0 Ledger test vector formatting changes Oct 13, 2023
murisi added a commit that referenced this pull request Oct 20, 2023
@murisi
Merge branch 'aleks+murisi/ledger-test-vector-generator-fix-0.22.0' (#…
b4b0525 
…1888)
Fraccaman added a commit that referenced this pull request Oct 23, 2023
@Fraccaman
Merge branch 'ledger-test-vector-generator-fix-0.22.0' (#1888)
5a2da8e 
* origin/aleks+murisi/ledger-test-vector-generator-fix-0.22.0:
  Added a changelog record.
  Test vector formatting changes.
tzemanovic added a commit that referenced this pull request Oct 24, 2023
@tzemanovic
Merge branch 'aleks+murisi/ledger-test-vector-generator-fix-0.22.0' (#…
9eb3ec3 
…1888)

* origin/aleks+murisi/ledger-test-vector-generator-fix-0.22.0:
  Added a changelog record.
  Test vector formatting changes.
@tzemanovic tzemanovic mentioned this pull request Oct 24, 2023
Merged
@tzemanovic tzemanovic merged commit 4d0d333 into main Oct 24, 2023
12 checks passed
@tzemanovic tzemanovic deleted the aleks+murisi/ledger-test-vector-generator-fix-0.22.0 branch October 24, 2023 11:26
brentstone pushed a commit that referenced this pull request Nov 11, 2023
@tzemanovic @brentstone
Merge branch 'aleks+murisi/ledger-test-vector-generator-fix-0.22.0' (#…
6f42f78 
…1888)

* origin/aleks+murisi/ledger-test-vector-generator-fix-0.22.0:
  Added a changelog record.
  Test vector formatting changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murisi murisi murisi left review comments

@tzemanovic tzemanovic tzemanovic approved these changes

@Fraccaman Fraccaman Awaiting requested review from Fraccaman

Assignees

@karbyshev karbyshev

@murisi murisi

Labels
client ledger testing wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karbyshev @tzemanovic @murisi