Removes fee panics from sdk #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariari
previously approved these changes
Sep 8, 2023
shared/src/ledger/signing.rs
Outdated
| @@ -277,10 +277,11 @@ pub async fn aux_signing_data< | |||
| }; | |||
|
|
|||
| if fee_payer == masp_tx_key().to_public() { | |||
| panic!( | |||
| return Err(Error::Tx(TxError::Other( | |||
There was a problem hiding this comment.
For this one it may be god to just return a Error::Other. Though it doesn't matter too much.
grarco
force-pushed
the
grarco/remove-sdk-fee-panics
branch
from
6c5f80e to
1a61ae6
Compare
Closed
grarco
force-pushed
the
grarco/remove-sdk-fee-panics
branch
from
1a61ae6 to
63467f7
Compare
adrianbrink
approved these changes
Sep 11, 2023
grarco
added a commit
that referenced
this pull request
Sep 21, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/grarco/remove-sdk-fee-panics: changelog: add #1878 Removes fee panics from sdk Adds fee-related errors to sdk
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes some wrong
panic!that were mistakenly brought into the sdk by the gas&fee pr.Indicate on which release or other PRs this topic is based on
v0.22.0
Checklist before merging to
draft