ledger: remove PoW/faucet #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
commented
Sep 7, 2023
Comment on lines
406
to
+408
| self.submit_tx(tx_bytes); | ||
| if !self.success() { | ||
| resp.code = tendermint::abci::Code::Err(1337); // TODO: submit_tx should return the correct error code + message |
There was a problem hiding this comment.
@batconjurer I had to add this otherwise it kept trying to send the tx (cc @grarco )
grarco
reviewed
Sep 8, 2023
apps/src/lib/client/signing.rs
Outdated
There was a problem hiding this comment.
I think this file keeps coming back but we don't actually need it
grarco
reviewed
Sep 8, 2023
core/src/types/storage.rs
Outdated
| @@ -540,6 +540,18 @@ impl Key { | |||
| self.segments.first() | |||
| } | |||
|
|
|||
| /// Return the owner of this subspace. None if empty or not an Address. | |||
| pub fn owner(&self) -> Option<Address> { | |||
Closed
Fraccaman
force-pushed
the
fraccaman/remove-pow
branch
from
6ac3fae to
feae687
Compare
Fraccaman
added a commit
that referenced
this pull request
Sep 20, 2023
* origin/fraccaman/remove-pow: ledger: remove faucet, remove pow-for-fee
grarco
previously approved these changes
Sep 20, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/fraccaman/remove-pow: added changelog ledger: remove faucet, remove pow-for-fee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
pow-for-feefeatureIndicate on which release or other PRs this topic is based on
Checklist before merging to
draft