Rework voting on Ethereum tallies across epoch boundaries #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/eth-voting-power
branch
from
337ce81 to
9051527
Compare
sug0
force-pushed
the
tiago/eth-voting-power
branch
from
9051527 to
95340e7
Compare
batconjurer
reviewed
Sep 7, 2023
batconjurer
reviewed
Sep 7, 2023
batconjurer
reviewed
Sep 7, 2023
sug0
force-pushed
the
tiago/eth-voting-power
branch
from
070ef0d to
23db15f
Compare
Instead of accounting for votes on Ethereum tallies based on the average voting power available across all epochs the tally took place in, we account for the maximum voting power found across all these epochs.
sug0
force-pushed
the
tiago/eth-voting-power
branch
from
23db15f to
8d067dd
Compare
batconjurer
previously approved these changes
Sep 11, 2023
Closed
tzemanovic
reviewed
Sep 18, 2023
tzemanovic
previously approved these changes
Sep 18, 2023
Co-authored-by: Tomas Zemanovic <[email protected]>
sug0
force-pushed
the
tiago/eth-voting-power
branch
from
504e66d to
8049d74
Compare
2 tasks
sug0
added a commit
that referenced
this pull request
Sep 21, 2023
Closed
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/tiago/eth-voting-power: Changelog for #1865 Remove explicit unreachable match arm Rework voting across epochs on Ethereum tallies Multiply Amount with FractionalVotingPower Convert Uint to Amount with 0 denom Append validators to storage using new testing util Add eth testing util to append validators to storage Write `PosQueries::get_total_voting_power` based on `get_total_consensus_stake` Make `get_total_consensus_stake` public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1288
This PR changes the way voting across epochs on Ethereum tallies works. Instead of accounting for the average voting power available across all epochs$E$ some tally $t$ takes place in, $t$ is considered $2/3 \max(\sigma(e) : e \in E)$ , where $\sigma$ is the function that returns the voting power available in the input epoch.
seenif its accumulated voting power is greater thanWith this strategy, tallies won't stall if they cross epoch boundaries, while still respecting the Tendermint BFT protocol's safety property (i.e. linearizability is preserved).
Indicate on which release or other PRs this topic is based on
v0.22.0Checklist before merging to
draft