Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger test vector generator fixes for 0.21.1 #1843

Closed
wants to merge 14 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/src/lib/client/tx.rs
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,7 @@ where
signing_data,
)
};
signing::generate_test_vector(client, &mut ctx.wallet, &tx_builder).await;

if args.tx.dump_tx {
tx::dump_tx(&args.tx, tx_builder);
Expand Down Expand Up @@ -956,6 +957,7 @@ where
)
.await?
};
signing::generate_test_vector(client, &mut ctx.wallet, &tx_builder).await;

if args.tx.dump_tx {
tx::dump_tx(&args.tx, tx_builder);
Expand Down
8 changes: 4 additions & 4 deletions core/src/types/transaction/account.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ pub struct InitAccount {
/// for signature verification of transactions for the newly created
/// account.
pub public_keys: Vec<common::PublicKey>,
/// The VP code hash
pub vp_code_hash: Hash,
/// The account signature threshold
pub threshold: u8,
/// The VP code hash
pub vp_code_hash: Hash,
}

/// A tx data type to update an account's validity predicate
Expand All @@ -41,12 +41,12 @@ pub struct InitAccount {
pub struct UpdateAccount {
/// An address of the account
pub addr: Address,
/// The new VP code hash
pub vp_code_hash: Option<Hash>,
/// Public keys to be written into the account's storage. This can be used
/// for signature verification of transactions for the newly created
/// account.
pub public_keys: Vec<common::PublicKey>,
/// The account signature threshold
pub threshold: Option<u8>,
/// The new VP code hash
pub vp_code_hash: Option<Hash>,
}
Loading