Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBC E2E test with Hermes #1797

Merged
merged 11 commits into from
Jan 13, 2024
Merged

Add IBC E2E test with Hermes #1797

merged 11 commits into from
Jan 13, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Aug 9, 2023

Describe your changes

closes #773
depends on #2237
Add a new IBC E2E test with Hermes relaying

Indicate on which release or other PRs this topic is based on

#1784 0.28.0 0.29.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 mentioned this pull request Aug 11, 2023
2 tasks
@yito88 yito88 force-pushed the yuji/add-ibc-e2e-hermes branch 2 times, most recently from be6221f to 0fc6c84 Compare August 15, 2023 13:45
@yito88 yito88 force-pushed the yuji/add-ibc-e2e-hermes branch from 0fc6c84 to 77acd40 Compare August 28, 2023 13:11
@cwgoes cwgoes mentioned this pull request Oct 20, 2023
23 tasks
@yito88 yito88 force-pushed the yuji/add-ibc-e2e-hermes branch from 77acd40 to 5eb2132 Compare November 23, 2023 21:02
@yito88 yito88 force-pushed the yuji/add-ibc-e2e-hermes branch from 3127992 to 2941416 Compare December 8, 2023 15:00
@yito88 yito88 requested review from tzemanovic and sug0 December 11, 2023 10:08
@yito88 yito88 marked this pull request as ready for review December 11, 2023 10:08
tests/src/e2e/setup.rs Show resolved Hide resolved
@tzemanovic
Copy link
Member

the e2e test failed on 1st attempt, retrying

@sug0 sug0 self-requested a review December 12, 2023 13:31
Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah you're right, oops. looks like it failed again.

@yito88
Copy link
Member Author

yito88 commented Dec 12, 2023

ah, it should fail because Hermes for Namada 0.28.0 (1.7.1-namada-beta5) is required.
For CI, #2237 is required to build Hermes with the target Namada.

@sug0
Copy link
Collaborator

sug0 commented Dec 12, 2023

I see. we should merge #2237 into draft before this pr then

@sug0 sug0 self-requested a review December 12, 2023 22:15
sug0
sug0 previously approved these changes Dec 12, 2023
@yito88 yito88 mentioned this pull request Dec 13, 2023
2 tasks
@yito88
Copy link
Member Author

yito88 commented Jan 3, 2024

Rebased. The E2E test passed with Hermes 1.7.4-namada-beta6.

@yito88 yito88 mentioned this pull request Jan 3, 2024
tzemanovic added a commit that referenced this pull request Jan 9, 2024
* origin/yuji/add-ibc-e2e-hermes:
  clean unneeded stuff
  add changelog
  set chain ID
  build hermes in CI
  add sleep
  wait for compiling
  for clippy
  fix waiting for the second block
  fix e2e script
  CI runs IBC e2e test with Hermes
  add IBC e2e test with Hermes
@brentstone brentstone merged commit c24d0e8 into main Jan 13, 2024
14 of 15 checks passed
@brentstone brentstone deleted the yuji/add-ibc-e2e-hermes branch January 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End-to-end IBC tests using the Hermes relayer
4 participants