Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable feature from integration tests #1771

Merged
merged 46 commits into from
Sep 25, 2023

Conversation

batconjurer
Copy link
Member

Describe your changes

This refactors the integrations tests using generic I/O. This allows use to remove the unstable feature gate.

Indicate on which release or other PRs this topic is based on

Depends on #1746

@batconjurer batconjurer requested a review from tzemanovic July 27, 2023 08:49
tzemanovic
tzemanovic previously approved these changes Jul 28, 2023
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! (I tried this together with #1768)

@tzemanovic
Copy link
Member

we could remove nightly from tests builds now - even though it's not 100% necessary it would help with reusing build artifacts with stable build

@tzemanovic tzemanovic mentioned this pull request Aug 29, 2023
2 tasks
@batconjurer batconjurer mentioned this pull request Sep 13, 2023
Fraccaman added a commit that referenced this pull request Sep 25, 2023
* origin/bat/feature/int-tests-io:
  [fix]: Fixed removing tokio dep from wasm targeted builds
  [chore] Merging in v0.22
  [feat]: Refactored the masp integration tests to no longer need the nightly feature
  [chore]: merge in v0.21.1
  [chore]: Formatting
  [feat]: After rebasing on bat/generic-io, need to make io read methods async for integration testing
  [fix]: Fixing downstream async io changes from bat/generic-io
  [feat]: Refactored the masp integration tests to no longer need the nightly feature
  [chore]: merge in v0.21.1
  [chore]: Formatting
  [feat]: After rebasing on bat/generic-io, need to make io read methods async for integration testing
  [fix]: Fixing downstream async io changes from bat/generic-io
  [chore]: rebasing on bat/generic-io
  [feat]: Refactored the masp integration tests to no longer need the nightly feature
  [chore]: Formatting
  [feat]: After rebasing on bat/generic-io, need to make io read methods async for integration testing
  [fix]: Fixing downstream async io changes from bat/generic-io
  [chore]: rebasing on bat/generic-io
  [feat]: Refactored the masp integration tests to no longer need the nightly feature
  [fix]: Fixing downstream async io changes from bat/generic-io
  [chore]: rebasing on bat/generic-io
  [feat]: Refactored the masp integration tests to no longer need the nightly feature
  [fix]: Fixing downstream async io changes from bat/generic-io
  [chore]: rebasing on bat/generic-io
  [feat]: Refactored the masp integration tests to no longer need the nightly feature
  [chore]: rebasing on bat/generic-io
  [feat]: Refactored the masp integration tests to no longer need the nightly feature
  [feat]: Refactored the masp integration tests to no longer need the nightly feature
@brentstone brentstone merged commit d789dda into main Sep 25, 2023
@brentstone brentstone deleted the bat/feature/int-tests-io branch September 25, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants