Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CLI logic into apps/lib #1736

Closed
wants to merge 4 commits into from
Closed

Move CLI logic into apps/lib #1736

wants to merge 4 commits into from

Conversation

batconjurer
Copy link
Member

@batconjurer batconjurer commented Jul 19, 2023 •
edited
Loading

This PR moves the CLI logic for the client, wallet, and relayer binaries into apps/lib as methods on an new struct called CliApi. The purpose of this is two-fold:

  1. This logic can be re-used by integration tests
  2. When we make IO generic (in order to aid front end dev), we can set a default IO for the cli.

This PR depends on #1670

@batconjurer batconjurer requested a review from tzemanovic July 19, 2023 09:55
@batconjurer batconjurer mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic Awaiting requested review from tzemanovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@batconjurer