Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/disable encryption #1636

Merged
merged 13 commits into from
Jul 6, 2023
Merged

Murisi/disable encryption #1636

merged 13 commits into from
Jul 6, 2023

Conversation

murisi
Copy link
Collaborator

@murisi murisi commented Jul 2, 2023

Disabled encryption when sending transactions. This PR is based on #1607 which fixes a general malleability issue with Namada transactions. More concretely, transactions will go from looking like:

  • Tx
    • Header
    • Encrypted into one section:
      • Data
      • Code
      • Signature over Data & Code
    • Signature over Header & Encrypted

to looking like:

  • Tx
    • Header
    • Data
    • Code
    • Signature over Data & Code
    • Signature over Header & Data & Code & (Signature over Data & Code)

grarco
grarco previously approved these changes Jul 2, 2023
Copy link
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@murisi murisi force-pushed the murisi/disable-encryption branch from 4011541 to a327d19 Compare July 2, 2023 12:33
@murisi murisi force-pushed the murisi/disable-encryption branch from 151720c to 6cdcf8f Compare July 3, 2023 09:42
@murisi murisi force-pushed the murisi/disable-encryption branch from 6cdcf8f to 9028fe2 Compare July 4, 2023 11:41
This was referenced Jul 4, 2023
brentstone added a commit that referenced this pull request Jul 5, 2023
* murisi/disable-encryption:
  Added a changelog entry.
  Stop encrypting transactions in tests.
  Disable encrypting transactions when sending.
Fraccaman added a commit that referenced this pull request Jul 6, 2023
* origin/murisi/disable-encryption:
  Added a changelog entry.
  Stop encrypting transactions in tests.
  Disable encrypting transactions when sending.
@Fraccaman Fraccaman mentioned this pull request Jul 6, 2023
@brentstone brentstone merged commit 42ed311 into main Jul 6, 2023
@brentstone brentstone deleted the murisi/disable-encryption branch July 6, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants