Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TendermintMode in Namada config for new post-genesis validator #1549

Merged
merged 28 commits into from
Jun 14, 2023

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Jun 12, 2023

Based on #1553. Closes #1542.

@brentstone brentstone force-pushed the brent/fix-init-validator-tendermint-mode branch from 3c6ca89 to d36683b Compare June 12, 2023 20:59
@brentstone brentstone requested a review from Fraccaman June 13, 2023 04:45
@tzemanovic tzemanovic force-pushed the brent/fix-init-validator-tendermint-mode branch from fcc721b to 2748048 Compare June 13, 2023 09:17
tzemanovic added a commit that referenced this pull request Jun 13, 2023
tzemanovic
tzemanovic previously approved these changes Jun 13, 2023
@tzemanovic tzemanovic marked this pull request as ready for review June 13, 2023 09:22
Fraccaman added a commit that referenced this pull request Jun 13, 2023
* origin/brent/fix-init-validator-tendermint-mode:
  fix: remove invalid condition around prepare-proposal
  update TendermintMode in Namada config for new post-genesis validator
@Fraccaman Fraccaman mentioned this pull request Jun 13, 2023
@tzemanovic tzemanovic force-pushed the brent/fix-init-validator-tendermint-mode branch from f72d50b to 000e72d Compare June 13, 2023 09:42
Fraccaman added a commit that referenced this pull request Jun 13, 2023
Fraccaman added a commit that referenced this pull request Jun 13, 2023
* brent/fix-init-validator-tendermint-mode:
  changelog: add #1549
  test/e2e/pos_init_validator: ensure that node after init-validator works
  changelog: add #1553
  [ci] wasm checksums update
  test/pos: check is_validator for a new validator
  pos: fix is_validator to be epoch agnostic
  Namada 0.17.1
  changelog: add #1534
  [ci] wasm checksums update
  test/storage: fill-in block header for commit if missing
  test/e2e/ledger/genesis_validators: validator wait for tx block height
  rpc: use the new shell last_block query to find last committed block
  core/storage: impl Display for BlockHash
  core/time: impl Display for DateTimeUtc
  shared/queries/shell: expose the last committed block from storage
  core/storage: Store last committed block's hash and time with its height
  fix: remove invalid condition around prepare-proposal
  update TendermintMode in Namada config for new post-genesis validator
@tzemanovic
Copy link
Member

tzemanovic commented Jun 13, 2023

The state machine test failure is most-like a problem with pre-conditions because get_total_consensus_stake ends up being zero. It's not likely caused by the changes introduced here. Trace: https://github.com/anoma/namada/actions/runs/5253847650/jobs/9491877974?pr=1549

…thub.com/anoma/namada into brent/fix-init-validator-tendermint-mode

* 'brent/fix-init-validator-tendermint-mode' of https://github.com/anoma/namada:
  changelog: add #1549
  test/e2e/pos_init_validator: ensure that node after init-validator works
  fix: remove invalid condition around prepare-proposal
  update TendermintMode in Namada config for new post-genesis validator
  changelog: add #1553
  [ci] wasm checksums update
  test/pos: check is_validator for a new validator
  pos: fix is_validator to be epoch agnostic
  Namada 0.17.1
  changelog: add #1534
  [ci] wasm checksums update
  test/storage: fill-in block header for commit if missing
  test/e2e/ledger/genesis_validators: validator wait for tx block height
  rpc: use the new shell last_block query to find last committed block
  core/storage: impl Display for BlockHash
  core/time: impl Display for DateTimeUtc
  shared/queries/shell: expose the last committed block from storage
  core/storage: Store last committed block's hash and time with its height
Fraccaman added a commit that referenced this pull request Jun 14, 2023
* origin/brent/fix-init-validator-tendermint-mode:
  client: mention to restart the node after init validator
  changelog: add #1549
  test/e2e/pos_init_validator: ensure that node after init-validator works
  changelog: add #1553
  [ci] wasm checksums update
  test/pos: check is_validator for a new validator
  pos: fix is_validator to be epoch agnostic
  Namada 0.17.1
  changelog: add #1534
  [ci] wasm checksums update
  test/storage: fill-in block header for commit if missing
  test/e2e/ledger/genesis_validators: validator wait for tx block height
  rpc: use the new shell last_block query to find last committed block
  core/storage: impl Display for BlockHash
  core/time: impl Display for DateTimeUtc
  shared/queries/shell: expose the last committed block from storage
  core/storage: Store last committed block's hash and time with its height
  fix: remove invalid condition around prepare-proposal
  update TendermintMode in Namada config for new post-genesis validator
  changelog: add #1549
  test/e2e/pos_init_validator: ensure that node after init-validator works
  fix: remove invalid condition around prepare-proposal
  update TendermintMode in Namada config for new post-genesis validator
Fraccaman pushed a commit that referenced this pull request Jun 14, 2023
@Fraccaman Fraccaman merged commit c58a463 into main Jun 14, 2023
@Fraccaman Fraccaman deleted the brent/fix-init-validator-tendermint-mode branch June 14, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config.toml inside $BASE_DIR/$CHAIN_ID/config.toml does not update
3 participants