Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: use hash instead of wasm blob #1474

Closed
wants to merge 141 commits into from
Closed
Show file tree
Hide file tree
Changes from 140 commits
Commits
Show all changes
141 commits
Select commit Hold shift + click to select a range
69deef8
Moving inner_tx from WrapperTx to Tx.
murisi Jan 27, 2023
6809564
Recombined Tx and SigningTx.
murisi Jan 27, 2023
e7f1e42
Hash the inner transaction code before placement inside wrapper.
murisi Jan 30, 2023
c4c2730
Added more error handling and streamlined (de)serialization code.
murisi Feb 6, 2023
2481db5
Fixed formatting and clippy.
murisi Feb 6, 2023
00559e9
[ci] wasm checksums update
github-actions[bot] Feb 6, 2023
2ba70d9
Renamed WrapperTxInQueue to TxInQueue to be more accurate.
murisi Feb 13, 2023
fe8bace
Removed inner_tx_code since it is redundant when with inner_tx.
murisi Feb 14, 2023
5a60a9f
[ci] wasm checksums update
github-actions[bot] Feb 14, 2023
bdfabc1
Add an extra data field to Txs that is hashed before signing.
murisi Feb 20, 2023
7c7b2a2
Reduced the size of InitValidator transactions.
murisi Feb 22, 2023
30aec50
Aligned the signing of reveal transactions with that of other transac…
murisi Feb 22, 2023
309335d
Removed encryption from transactions.
Mar 29, 2023
bbe5d06
Gave inner_tx a stronger type.
Mar 29, 2023
c440ab8
Made transaction data optional.
Mar 29, 2023
fd3a54c
Strengthened the typing of the Tx data field with SignedTxData.
Mar 30, 2023
4cff51d
Separated SignedOuterTxData from SignedTxData. This involved reclassi…
Mar 30, 2023
ccaa950
Restricted the contents of the data field of Tx.
Mar 31, 2023
e4cc937
Renamed the fields of outer transaction to avoid confusion.
Mar 31, 2023
6274db8
Now supply Vps and Txs with full transactions.
Apr 1, 2023
fcc691b
Made outer Tx data non-optional.
Apr 3, 2023
d944b9a
Moved out the InnerTx nested in the header.
Apr 4, 2023
1661782
Renamed outer Tx fields in protobuf to avoid ambiguities.
Apr 4, 2023
b132969
Replaced the inner_tx of Tx with InnerTx fields.
Apr 5, 2023
58bba84
Reduced usage of InnerTx.
Apr 5, 2023
27a4a40
Flattened Tx and InnerTx into one structure.
Apr 7, 2023
1f35ef4
Removed redundant InnerTx usages.
Apr 8, 2023
c4a2c5b
Move shielded transactions out of Transfer and into Tx.
Apr 10, 2023
fa045f5
Re-enabled submission of proposal code.
Apr 10, 2023
ccbcf49
Removed unnecessary fields in Tx. Cleaned up Transfer event creation …
Apr 11, 2023
45a2ad0
Removed the Signed structure as its not currently being used.
Apr 11, 2023
4115880
Deduplicatedd encryption code and tailored it for Section structure.
Apr 11, 2023
a3d861a
Added some documentation to the new Tx structure.
Apr 11, 2023
d2c9e45
Make it easier to update transaction headers.
Apr 11, 2023
6bfb0bc
Upgraded the version of the MASP crate that is used.
Apr 13, 2023
7ed4d07
Make proof reading during transaction validation safe.
Apr 14, 2023
19a7a6c
Separated header validation from header extraction.
Apr 15, 2023
b7d4279
Exclude signatures from MaspTx section hash so that references to it …
Apr 15, 2023
578ee00
Created a new Builder section to witness for Transaction sections.
Apr 15, 2023
b4bd77c
Now attach a Builder instance to Txs.
Apr 16, 2023
6c67c29
Allow the transaction code section to be contracted.
Apr 17, 2023
bd41e39
Added CLI flag to disable checks during transaction construction.
Mar 12, 2023
5b795da
Added function to convert Namada transaction to Ledger vector.
Apr 17, 2023
03a8b80
Simplified hashing so that its mostly based on Borsh.
Apr 17, 2023
81f31e8
Added code to save transactions if NAMADA_LEDGER_LOG_PATH enabled.
Apr 17, 2023
1ff057a
Added code to add transaction debug outputs. Started decoding MASP tr…
Apr 19, 2023
4b65a73
Added asset type decodings to the MaspBuilder section. Now use readab…
Apr 19, 2023
5b0e690
Added some bash scripts to generate test vectors.
Apr 19, 2023
625febe
Improved the formatting of test vectors.
Apr 19, 2023
2466df7
Increased the maximum proposal code size to 500000 so that proposal t…
Apr 20, 2023
56fae0b
Merged in main branch and fixed compiler errors.
Apr 22, 2023
aa656f9
Move chain id and expiration information into the header.
Apr 24, 2023
085408e
Simplified the TxInQueue data structure.
Apr 26, 2023
8c63af6
Applied cargo fmt and clippy.
Apr 26, 2023
389041b
cargo: use "rev" instead of branch name for masp
tzemanovic May 5, 2023
b3a64b7
more clippy fixes
tzemanovic May 5, 2023
ebeb193
cli: add conflicts_with UNCHECKED on FORCE and re-order
tzemanovic May 5, 2023
4d4f747
client/cli: look-up token aliases from wallet
tzemanovic May 5, 2023
4b2efa3
client: remove accidentally revived types file
tzemanovic May 5, 2023
385b2d6
test/shell/finalize_block: update test_undecryptable_returns_error_code
tzemanovic May 5, 2023
da456c9
test: update for tx API changes
tzemanovic May 5, 2023
a7076c1
core/proto/types: docstring fix
tzemanovic May 5, 2023
82961de
Merge branch 'base' into murisi/restructure-tx-merge
tzemanovic May 5, 2023
f8c993a
core/types/proto: docstring fix
tzemanovic May 5, 2023
40f2874
make fmt
tzemanovic May 5, 2023
0c266cc
Draft of wallet bip39 support
karbyshev Feb 1, 2023
02c7202
Fix help messages
karbyshev Feb 2, 2023
7bbb05c
Keypair / wallet recovery from mnemonic code
karbyshev Feb 2, 2023
fc8e920
Improve comments and messages
karbyshev Feb 2, 2023
3ef64e3
Improve messages
karbyshev Feb 2, 2023
85a0fa4
Refactoring
karbyshev Feb 2, 2023
186a026
Add test case
karbyshev Feb 2, 2023
e676ce8
Check if the public key hash already known
karbyshev Feb 3, 2023
8831c19
Fix comment
karbyshev Feb 3, 2023
50cb8ae
Zeroize user mnemonic phrase input
karbyshev Feb 5, 2023
5085ea6
Clean code, minor refactoring
karbyshev Feb 6, 2023
abccdc3
Apply suggestions from code review
karbyshev Feb 6, 2023
aa17313
Refactor
karbyshev Feb 6, 2023
fac8377
Support mnemonic codes only for ed25519 scheme.
karbyshev Feb 7, 2023
80dec43
Revert "Support mnemonic codes only for ed25519 scheme."
karbyshev Feb 10, 2023
b5a2c68
Add derivation paths
karbyshev Apr 12, 2023
3224619
feat: add HD derivation path support
karbyshev Apr 12, 2023
3d2b5fb
Rework CLI options; fix bugs
karbyshev Apr 18, 2023
8e136a2
Add unit tests for HD wallet functionality
karbyshev Apr 18, 2023
2b1b2a2
Warn user if path coin type and crypto scheme are incompatible
karbyshev Apr 18, 2023
700181a
Fix path hardening
karbyshev Apr 19, 2023
83454f5
Add error messages
karbyshev Apr 19, 2023
2bfcbe3
Remove outdated comment
karbyshev Apr 19, 2023
9d1ea52
Additional test cases for secp256k1
karbyshev Apr 20, 2023
5ec839d
Additional test cases for ed25519
karbyshev Apr 24, 2023
fd61678
Apply suggestions from code review
karbyshev May 4, 2023
cdb3633
Improve comment
karbyshev May 5, 2023
8defdb5
Simplify method signature
karbyshev May 5, 2023
6a404c8
Use Zeroizing instead of SecStr
karbyshev May 5, 2023
71a6b1b
Update Cargo.lock
karbyshev May 5, 2023
48b6a77
Fix dependencies
karbyshev May 5, 2023
f8408bc
Add changelog entry
karbyshev May 8, 2023
61909b4
wasm: update checksums
tzemanovic May 9, 2023
0383703
core/transaction: box wrapper and protocol tx type variants
tzemanovic May 9, 2023
dda4008
tx/pos: drop misformatted seed
tzemanovic May 9, 2023
82ecc71
tx_prelude: remove accidentally revived gov mod
tzemanovic May 9, 2023
5504002
vm_env: removed accidentally revived token mod
tzemanovic May 9, 2023
1ea07af
Update scripts/offline_generator.sh
murisi May 15, 2023
6d44744
Update scripts/online_generator.sh
murisi May 15, 2023
826947f
Fixed deprecated call to to_extended_full_viewing_key. Now combine se…
May 15, 2023
d2cb694
Removed unnecessary masp_proofs dependency from WASM modules.
May 19, 2023
23a1518
app/wallet: rm empty keys mod
tzemanovic May 19, 2023
11ca7ac
Corrected ther serialization of ciphertexts to account for length-pre…
May 19, 2023
0aff548
Merge remote-tracking branch 'origin/base' into aleks/wallet-determin…
karbyshev May 19, 2023
100f546
[ci] wasm checksums update
github-actions[bot] May 20, 2023
7b0d542
feat: disable multicore ff by default, make ShieldedUtils trait async
mateuszjasiuk May 18, 2023
ec64402
feat: point to the masp_proofs with correct multicore feature flag
mateuszjasiuk May 19, 2023
0dc1e08
wasm: update checksums
tzemanovic May 21, 2023
0cf7dab
changelog: add #1238
tzemanovic May 21, 2023
8025987
Merge branch 'mateusz/shared-sdk-integration-wip' (#1238)
tzemanovic May 21, 2023
7ffbd6d
Merge branch 'aleks/wallet-deterministic' (#1110)
tzemanovic May 21, 2023
4e6adf9
cli: add missing `--wallet-alias-force` and `--alias-force`
tzemanovic May 20, 2023
9d3614d
shared/tx/submit_validator_commission_change: print err even with force
tzemanovic May 20, 2023
01d5e2f
shared/tx: fix err variant typos
tzemanovic May 20, 2023
de50551
cli: rename Tx arg `tx_code_path` to `tx_reveal_code_path`
tzemanovic May 20, 2023
26f32ca
Merge branches 'tomas/rm-empty-keys-mod', 'tomas/missing-args-def', '…
tzemanovic May 21, 2023
1c09b7b
Merge branch 'tomas/fix-err-typos' (#1435)
tzemanovic May 21, 2023
55747fb
Merged in the latest base branch.
May 21, 2023
b6d90cc
Renamed CodeHash to Commitment to reflect its general usage.
May 21, 2023
b202b0f
Sync with tag 'v0.15.4'
tzemanovic May 21, 2023
db17079
Fixed the generation of test vectors for IBC transfers.
May 22, 2023
e23a95f
fix: zeroize passphrases
karbyshev May 22, 2023
722b629
Add changelog
karbyshev May 22, 2023
0e57a6b
[ci] wasm checksums update
github-actions[bot] May 22, 2023
fc7f2ca
Remove ABCI++ deps from Cargo files
sug0 May 22, 2023
a5a606f
Update Cargo lock file
sug0 May 22, 2023
1884d46
Remove ABCI++ commands from the Makefile
sug0 May 22, 2023
17a8e09
Merge branch 'aleks/wallet-zeroize' (#1443)
tzemanovic May 22, 2023
dd28154
Merge branch 'tiago/main/rm-abciplus-cargo-deps' (#1449)
tzemanovic May 22, 2023
1bcc0cd
Fixed online test vector generation.
May 23, 2023
93dd23f
Removed the unchecked and epoch flags since not all test vector gener…
May 23, 2023
a01e419
Merged in restructured tx code.
May 23, 2023
34f36bb
Fixed clippy issues and formatting. Added an std feature to enable te…
May 24, 2023
11a272b
[ci] wasm checksums update
github-actions[bot] May 24, 2023
548dfa4
sdk: use hash instead of wasm code
Fraccaman May 25, 2023
504f4de
fixup! sdk: use hash instead of wasm code
Fraccaman May 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/features/1110-wallet-deterministic.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Implements HD wallet derivation / recovery from a given mnemonic code
([\#1110](https://github.com/anoma/namada/pull/1110))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/1093-signable-txs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Make Namada transactions signable on hardware constrained wallets by making
them smaller. ([#1093](https://github.com/anoma/namada/pull/1093))
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- Added `multicore` feature flag to the namada and namada_core
crate that can be switched off for JS WASM build.
Additionally, changed the `trait ShieldedUtils` to be async.
([\#1238](https://github.com/anoma/namada/pull/1238))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/1425-wallet-zeroize.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Zeroizes memory containing passphrases in wallet.
([\#1425](https://github.com/anoma/namada/issues/1425))
2 changes: 0 additions & 2 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@ on:
push:
branches:
- main
- maint-*
- "!eth-bridge-integration"
# Run in PRs with conflicts (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request)
pull_request_target:
branches:
- main
- maint-*
- "!eth-bridge-integration"
types: [opened, synchronize, reopened]
workflow_dispatch:
Expand Down
Loading