Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common sub-expression elimination in inflation calculation #1444

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Common sub-expression elimination in inflation calculation #1444

merged 1 commit into from
Jun 5, 2023

Conversation

cwgoes
Copy link
Collaborator

@cwgoes cwgoes commented May 22, 2023

(as title)

@cwgoes cwgoes requested a review from brentstone May 22, 2023 10:15
@cwgoes
Copy link
Collaborator Author

cwgoes commented May 22, 2023

cc @brentstone typically we should give names to repeatedly-used expressions and only calculate their values once

brentstone
brentstone approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the catch

cwgoes added a commit that referenced this pull request May 24, 2023
@cwgoes
Merge branch 'cwgoes/cse-in-inflation' (#1444)
fb5b678 
* cwgoes/cse-in-inflation:
  Common sub-expression elimination in inflation calculation
cwgoes added a commit that referenced this pull request May 24, 2023
@cwgoes
changelog: add #1444
f101a69
@tzemanovic tzemanovic mentioned this pull request May 24, 2023
Closed
@Fraccaman Fraccaman merged commit 49e9aa3 into main Jun 5, 2023
@Fraccaman Fraccaman deleted the cwgoes/cse-in-inflation branch June 5, 2023 03:18
tzemanovic added a commit that referenced this pull request Jun 8, 2023
@tzemanovic
fix typo in #1444 changelog
19eae03
tzemanovic added a commit that referenced this pull request Jun 12, 2023
@tzemanovic
Merge branch 'tomas/fix-unreleased-changelogs' (#1525)
4a8991c 
* tomas/fix-unreleased-changelogs:
  fix typo in #1444 changelog
  remove unnecessary changelogs
Fraccaman added a commit that referenced this pull request Jun 13, 2023
@Fraccaman
Merge tag 'v0.17.1' into draft-test
df7c22a 
Namada 0.17.0 is a scheduled minor release featuring several improvements to the slashing mechanism, wallet address derivation, transaction structure and the ledger stability.

* tag 'v0.17.1':
  Namada 0.17.1
  fix: change installer link
  fix: change installer link
  fix: wasm unit remove hardcoded vp hash
  test/e2e/slashing: wait for first block on copied validator before tx
  changelog: add #1534
  [ci] wasm checksums update
  test/storage: fill-in block header for commit if missing
  test/e2e/ledger/genesis_validators: validator wait for tx block height
  rpc: use the new shell last_block query to find last committed block
  core/storage: impl Display for BlockHash
  core/time: impl Display for DateTimeUtc
  shared/queries/shell: expose the last committed block from storage
  core/storage: Store last committed block's hash and time with its height
  fix typo in #1444 changelog
  remove unnecessary changelogs
brentstone added a commit that referenced this pull request Jul 5, 2023
@brentstone
Merge branch 'murisi/separate-signing' (#1498)
549c08f 
* murisi/separate-signing:
  Added changelog entry.
  Factored out the submission of the reveal PK transaction.
  Simplified the reveal PK transaction construction flow. Factored chain_id reading from submit functions.
  Allow Tx builders to take verification keys.
  Increased usage of PublicKeys relative to SecretKeys in tx construction.
  Only reveal a public key when the signer is an implicit address.
  Now only use TxBroadcastData::Wrapper for non dry runs.
  Now update proof of work solution in transaction header.
  Separating out the reveal PK transaction construction.
  Separate transaction building from signing from submission.
  Removed unnecessary header updates for dry runs.
  fixup! Merge 'origin/fraccaman/fix-sdk-tx-with-hash' (#1474)
  sdk: use hash instead of wasm code
  Revert "Merge 'origin/fraccaman/fix-sdk-tx-with-hash' (#1474)"
  Revert "fixup! Merge 'origin/fraccaman/fix-sdk-tx-with-hash' (#1474)"
  fixup!: don't call `process_slashes` within `advance_epoch`
  clean up logging
  fix clippy
  remove test code until slash pool transfers are solved
  rip slash pool
  fixup! Merge 'origin/fraccaman/fix-sdk-tx-with-hash' (#1474)
  get_slashed_amount: inclusive on infraction epoch
  add cli to sdk impl for tx unjail
  sdk: use hash instead of wasm code
  make find_slashes_in_ranges inclusive on end epoch
  withdraw: fix bounds for collecting slashes for an unbond
  aesthetic cleaning
  Update WASM checksums.
  revert bound cleaning for readability
  refactor slash lookup
  fixup! add cubic_slash_window_length to bounds (maybe still needs change)
  update changelog
  Remove unused module
  Fixed local tx prover dependency regression.
  use cometbft binary
  Fixed the header of transactions in dry_run.
  Updated the WASM checksums.
  remove unused cubic slash function
  changelog: add #1444
  fixup! store total bond sums of each validator for efficient computation
  refactor epoch offsets with params methods
  store total bond sums of each validator for efficient computation
  pos/lib.rs: WIP fix things inside of `bonds_and_unbonds`
  fix PoS client query related functions
  fix `bond_amount`
  pos: cubic slashing with new procedure for recording and unbonding/withdrawing
Fraccaman pushed a commit that referenced this pull request Jul 5, 2023
@cwgoes @Fraccaman
changelog: add #1444
a11b925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentstone brentstone brentstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwgoes @brentstone @Fraccaman