Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warnings for fallible Bridge pool relays #1340

Merged
merged 14 commits into from
May 10, 2023

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented May 9, 2023

Partially solves #1292
(Missing validator set update UX improvements)

@sug0 sug0 force-pushed the tiago/ethbridge/warn-bp-transfer branch from 8b24a1a to 1296b2e Compare May 10, 2023 09:00
@sug0 sug0 marked this pull request as ready for review May 10, 2023 09:33
@sug0 sug0 requested review from juped, gijswijs and cwgoes May 10, 2023 09:34
@sug0 sug0 merged commit fd0ef46 into tiago/ethbridge/main May 10, 2023
@sug0 sug0 deleted the tiago/ethbridge/warn-bp-transfer branch May 10, 2023 09:34
@sug0 sug0 mentioned this pull request May 10, 2023
sug0 added a commit that referenced this pull request May 10, 2023
@cwgoes
Copy link
Collaborator

cwgoes commented May 10, 2023

I'm a little bit confused. What does it mean for an event to have been relayed, but not have a quorum of validator signatures? I thought the Ethereum-side contracts checked that all transfers from Namada have a quorum of validator signatures - shouldn't it be impossible to relay an event until it does?

@sug0
Copy link
Collaborator Author

sug0 commented May 10, 2023

@cwgoes here's the scenario:

  1. you relay some transfers in the bridge pool with nonce $N$
  2. the contract gets updated with nonce $N+1$
  3. the event arrives in namada, and gets a quorum of votes behind it
  4. namada's bridge pool nonce is incremented to $N+1$
  5. a bridge pool merkle root is signed together with $N+1$
  6. a quorum of nodes agree on the new merkle root signed together with $N+1$
  7. finally, a new relay may be done for $N+1$

there's a bit of delay between relays because of this flow

@cwgoes
Copy link
Collaborator

cwgoes commented May 10, 2023

Ah, you mean a quorum of validators agreeing on step (3), that the Ethereum-side contracts have confirmed the transfers. That makes sense but I think we're overloading the word "relay" a bit much, maybe we could say "relayed to Ethereum" or "relayed from Ethereum" so that it's not ambiguous?

@sug0 sug0 mentioned this pull request May 11, 2023
sug0 added a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants