Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/restructure tx #1280

Merged
merged 50 commits into from
Jun 5, 2023
Merged

Murisi/restructure tx #1280

merged 50 commits into from
Jun 5, 2023

Conversation

murisi
Copy link
Collaborator

@murisi murisi commented Apr 10, 2023

This is an attempt to achieve #1255 . Overall the main changes introduced by this branch are:

  • Instead of having an outer transaction structure containing an inner transaction, there is now a single transaction structure containing a flat list of sections.
  • Instead of wrapping inner transactions in a structure that supplies a signature, the unsigned data is added as a section to the transaction at the same level as it corresponding signature section.
  • The WASM code now receives a Tx object instead of a data byte vector. This is because the data section's signature is stored in a different section, and because the extra data also resides in a separate section.
  • Encryption is now done separately after all signing is complete - in particular this means that there are no longer any signatures over encrypted data.
  • Upgraded the MASP client and validation code to use the latest MASP crate.
  • Added a builder section to Txs where the auxiliary inputs that were used to construct a MASP transaction can be stored. This may be useful for hardware wallets when validating a given Transaction object.

murisi and others added 28 commits January 27, 2023 12:52
@murisi murisi force-pushed the murisi/restructure-tx branch from def39c9 to c4a2c5b Compare April 10, 2023 18:33
@murisi murisi force-pushed the murisi/restructure-tx branch from db32d3b to e5b5d8b Compare April 14, 2023 14:23
@murisi murisi force-pushed the murisi/restructure-tx branch from e5b5d8b to 6bfb0bc Compare April 14, 2023 15:08
@murisi murisi force-pushed the murisi/restructure-tx branch from 39faf81 to 7ed4d07 Compare April 15, 2023 07:43
@murisi murisi force-pushed the murisi/restructure-tx branch from 585b70c to 625febe Compare April 19, 2023 14:39
@adrianbrink adrianbrink mentioned this pull request May 12, 2023
10 tasks
@juped juped added this to the 0.17 milestone May 15, 2023
@Fraccaman Fraccaman merged commit 56fae0b into main Jun 5, 2023
@Fraccaman Fraccaman deleted the murisi/restructure-tx branch June 5, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants