-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/restructure tx #1280
Merged
Merged
Murisi/restructure tx #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fying Txs as InnerTxs.
murisi
force-pushed
the
murisi/restructure-tx
branch
from
April 10, 2023 18:33
def39c9
to
c4a2c5b
Compare
murisi
force-pushed
the
murisi/restructure-tx
branch
from
April 14, 2023 14:23
db32d3b
to
e5b5d8b
Compare
murisi
force-pushed
the
murisi/restructure-tx
branch
from
April 14, 2023 15:08
e5b5d8b
to
6bfb0bc
Compare
murisi
force-pushed
the
murisi/restructure-tx
branch
from
April 15, 2023 07:43
39faf81
to
7ed4d07
Compare
…le token name in Ledger vectors.
murisi
force-pushed
the
murisi/restructure-tx
branch
from
April 19, 2023 14:39
585b70c
to
625febe
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to achieve #1255 . Overall the main changes introduced by this branch are:
Tx
object instead of a data byte vector. This is because the data section's signature is stored in a different section, and because the extradata
also resides in a separate section.Tx
s where the auxiliary inputs that were used to construct a MASP transaction can be stored. This may be useful for hardware wallets when validating a given Transaction object.