Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle native inflation rewards for native tokens #1198

Closed
wants to merge 3 commits into from

Conversation

murisi
Copy link
Collaborator

@murisi murisi commented Mar 7, 2023

Fixing the handling of positive Namada token rewards for possession of shielded Namada tokens. The approach is taken is as follows:

  • Removed the prev_root field of ConversionState structure for now since it seems to never be read.
  • Conversions from a previous epoch to a new epoch are done directly without reference to the native token in the zeroth epoch. It seems to have been circular references to the native token that was causing positive native inflation rewards to fail E2E tests.
  • Native token rewards given for possession of other types of shielded assets are first deflated. This saves the client from having to convert native tokens from multiple epochs into the latest whilst allowing inflation to still be expressed in terms of the latest native token.

@murisi murisi force-pushed the murisi/native-rewards branch from aa7bba1 to 0fd9d77 Compare March 15, 2023 08:35
@murisi
Copy link
Collaborator Author

murisi commented Mar 15, 2023

pls update wasm

@adrianbrink adrianbrink changed the title Now handle native inflation rewards for native tokens. Handle native inflation rewards for native tokens May 12, 2023
@adrianbrink adrianbrink mentioned this pull request May 12, 2023
10 tasks
@murisi murisi closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant