Relay validator set updates #1157
Conversation
sug0
force-pushed
the
tiago/ethbridge/smart-contract-calls
branch
from
4f3a1ab to
c583fbe
Compare
| [u8; 32], | ||
| [u8; 32], | ||
| Vec<Signature>, | ||
| ) = abi_decode_struct(encoded_proof); |
There was a problem hiding this comment.
I seems like we are doing lots of unnecessary rounds of serialization.
There was a problem hiding this comment.
the RPC method could return a non-abi encoded data response. right now it borsh serializes the abi encoding of the data. CLI commands requesting a proof are kind of obsolete now, but if we wanted to keep them anyway (so users could potentially implement shell scripts around this or smth?), they could be responsible for returning the ABI encoding of the data queried from our RPC endpoints
There was a problem hiding this comment.
I think it makes more sense to borsh serialize the raw struct and down the road, if some script needs abi encoding, it can call abi encoding on the raw struct itself. I don't think that's an unreasonable burden to put on people implementing their own scripts.
I just feel like we have a lot of artifact code that I would like to clear out. This damn repo is complicated enough as it is.
There was a problem hiding this comment.
I feel the same. I'll work on this later though, right now it's out of the scope of this PR
EDIT: opened #1160
| println!("{transf_result:?}"); | ||
| } | ||
|
|
||
| // NOTE: there's a bug (or feature?!) in ethers, where |
Based on #1159.
Implements item 6) of #242.