Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block height in storage after epoch change #599

Closed
sug0 opened this issue Oct 14, 2022 · 1 comment
Closed

Fix block height in storage after epoch change #599

sug0 opened this issue Oct 14, 2022 · 1 comment
Labels
bug Something isn't working ethereum-bridge

Comments

@sug0
Copy link
Collaborator

sug0 commented Oct 14, 2022

The block height of a new epoch updated in storage, after we call finalize_block(), is wrong. We need to store the previous height, rather than the next height.

The fix is fairly simple. We just need to apply this patch in reverse.

We also need to fix a related unit test (test_can_send_validator_set_update), or simply #[ignore] it for now.

@sug0
Copy link
Collaborator Author

sug0 commented Oct 14, 2022

Linked PR #594
We can just patch eth-bridge-integration with those changes, as well

@sug0 sug0 closed this as completed Nov 2, 2022
sug0 added a commit that referenced this issue Nov 2, 2022
The related issues were #599 and #600, which are fixed on the branch
leading up to this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ethereum-bridge
Projects
None yet
Development

No branches or pull requests

1 participant