Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling with abcipp and set up CI to check it #497

Closed
4 tasks
james-chf opened this issue Sep 21, 2022 · 3 comments · Fixed by #754 or #824
Closed
4 tasks

Fix compiling with abcipp and set up CI to check it #497

james-chf opened this issue Sep 21, 2022 · 3 comments · Fixed by #754 or #824

Comments

@james-chf
Copy link
Contributor

james-chf commented Sep 21, 2022

ABCI 0.19 (formerly known as ABCI++) is coming in Tendermint v0.38 and will provide us with vote extensions, which was used by the original design of the Ethereum bridge. Code to do with it is guarded behind the abcipp flag, and --no-default-features should be used also. We should run CI to make sure that our ABCI 0.19 code continues to compile/pass tests.

Compiling with abcipp currently doesn't work on main or eth-bridge-integration branches (as of 2022-11-04). We should fix up in main first and have a CI job to at least cargo check it, then do the same for eth-bridge-integration.

@james-chf james-chf changed the title Set up CI for ABCI 0.19 on eth-bridge-integration Set up CI for ABCI++ on eth-bridge-integration Oct 12, 2022
@james-chf
Copy link
Contributor Author

This has broken a couple of times

@james-chf james-chf self-assigned this Oct 28, 2022
@james-chf james-chf moved this to Todo in Namada-Old Oct 28, 2022
@james-chf james-chf removed their assignment Nov 4, 2022
@james-chf james-chf changed the title Set up CI for ABCI++ on eth-bridge-integration Fix compiling with abcipp and set up CI to check it Nov 4, 2022
@james-chf james-chf self-assigned this Nov 9, 2022
@james-chf james-chf moved this from Todo to WIP in Namada-Old Nov 9, 2022
@james-chf james-chf moved this from WIP to Pending Devnet in Namada-Old Nov 15, 2022
@james-chf james-chf moved this from Pending Devnet to WIP in Namada-Old Nov 15, 2022
@james-chf james-chf moved this from WIP to Pending Devnet in Namada-Old Nov 16, 2022
@james-chf james-chf linked a pull request Nov 16, 2022 that will close this issue
@james-chf james-chf moved this from Pending Devnet to WIP in Namada-Old Nov 18, 2022
@james-chf james-chf moved this from WIP to Pending Devnet in Namada-Old Nov 18, 2022
@james-chf james-chf linked a pull request Nov 18, 2022 that will close this issue
This was linked to pull requests Nov 25, 2022
@james-chf james-chf moved this from Pending Devnet to WIP in Namada-Old Nov 25, 2022
Repository owner moved this from WIP to Tested in Devnet in Namada-Old Nov 30, 2022
@james-chf james-chf reopened this Dec 8, 2022
@james-chf james-chf reopened this Dec 8, 2022
@james-chf james-chf removed their assignment Dec 8, 2022
@james-chf james-chf moved this from Tested in Devnet to Pending Devnet in Namada-Old Dec 8, 2022
@cwgoes
Copy link
Collaborator

cwgoes commented Jan 13, 2023

@james-chf is this relevant any more?

@james-chf
Copy link
Contributor Author

This is done

@github-project-automation github-project-automation bot moved this from Pending Devnet to Tested in Devnet in Namada-Old Jan 16, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
2 participants