-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiling with abcipp
and set up CI to check it
#497
Comments
james-chf
changed the title
Set up CI for ABCI 0.19 on
Set up CI for ABCI++ on Oct 12, 2022
eth-bridge-integration
eth-bridge-integration
Merged
This has broken a couple of times |
james-chf
changed the title
Set up CI for ABCI++ on
Fix compiling with Nov 4, 2022
eth-bridge-integration
abcipp
and set up CI to check it
This was referenced Nov 4, 2022
This was
linked to
pull requests
Nov 25, 2022
Repository owner
moved this from WIP
to Tested in Devnet
in Namada-Old
Nov 30, 2022
@james-chf is this relevant any more? |
This is done |
github-project-automation
bot
moved this from Pending Devnet
to Tested in Devnet
in Namada-Old
Jan 16, 2023
phy-chain
pushed a commit
to phy-chain/namada
that referenced
this issue
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ABCI 0.19 (formerly known as ABCI++) is coming in Tendermint v0.38 and will provide us with vote extensions, which was used by the original design of the Ethereum bridge. Code to do with it is guarded behind the
abcipp
flag, and--no-default-features
should be used also. We should run CI to make sure that our ABCI 0.19 code continues to compile/pass tests.Compiling with
abcipp
currently doesn't work onmain
oreth-bridge-integration
branches (as of 2022-11-04). We should fix up inmain
first and have a CI job to at leastcargo check
it, then do the same foreth-bridge-integration
.main
abcipp
feature flag #754make check-abcipp
andmake clippy-abcipp
#869eth-bridge-integration
main
make check-abcipp
in CI #824eth-bridge-integration
The text was updated successfully, but these errors were encountered: