Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Ethereum bridge validity predicate #114

Closed
5 tasks done
Tracked by #128
james-chf opened this issue May 19, 2022 · 2 comments
Closed
5 tasks done
Tracked by #128

Implement the Ethereum bridge validity predicate #114

james-chf opened this issue May 19, 2022 · 2 comments

Comments

@james-chf
Copy link
Contributor

james-chf commented May 19, 2022

This is a top-level issue for tracking development of the EthBridge VP

Related: transfer logic for multitokens more generally will be covered by #132

@james-chf james-chf changed the title Multitoken accounts Make transfers work with multitoken accounts May 19, 2022
@james-chf james-chf changed the title Make transfers work with multitoken accounts Support multitoken accounts May 24, 2022
@james-chf james-chf self-assigned this May 31, 2022
@james-chf james-chf changed the title Support multitoken accounts #EthBridge multitoken account Jun 1, 2022
@james-chf james-chf changed the title #EthBridge multitoken account #EthBridge variable supply multitoken account Jun 1, 2022
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@james-chf james-chf changed the title #EthBridge variable supply multitoken account Add variable supply multitoken logic to the #EthBridge VP Jul 21, 2022
@james-chf james-chf moved this from WIP to Todo in Namada-Old Jul 21, 2022
@james-chf james-chf moved this from Todo to WIP in Namada-Old Aug 12, 2022
@james-chf james-chf moved this from WIP to Todo in Namada-Old Aug 12, 2022
@james-chf james-chf changed the title Add variable supply multitoken logic to the #EthBridge VP Ethereum bridge VP Aug 12, 2022
@james-chf james-chf moved this from Todo to WIP in Namada-Old Aug 12, 2022
@james-chf james-chf changed the title Ethereum bridge VP #EthBridge VP Aug 24, 2022
@james-chf james-chf moved this from WIP to Todo in Namada-Old Sep 2, 2022
@james-chf james-chf changed the title #EthBridge VP Implement the Ethereum bridge validity predicate Sep 27, 2022
@james-chf james-chf removed the namada label Oct 11, 2022
@batconjurer batconjurer moved this from Todo to WIP in Namada-Old Oct 11, 2022
@james-chf james-chf moved this from WIP to Low-prio in Namada-Old Nov 7, 2022
@cwgoes
Copy link
Collaborator

cwgoes commented Jan 13, 2023

@james-chf what is the status of this? still blocked on #432 ?

@james-chf
Copy link
Contributor Author

I'll check if #432 is finished and has test coverage, once that's done this issue can be closed

@cwgoes cwgoes added this to the 0.14 milestone Jan 16, 2023
@tzemanovic tzemanovic modified the milestones: 0.14, 0.15 Feb 8, 2023
@james-chf james-chf moved this from Low-prio to Pending Devnet in Namada-Old Feb 8, 2023
@james-chf james-chf removed their assignment Feb 9, 2023
@sug0 sug0 closed this as completed Apr 11, 2023
@github-project-automation github-project-automation bot moved this from Pending Devnet to Tested in Devnet in Namada-Old Apr 11, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
* Begin setting up KeyRing & accounts storage

* Adding a simple typed state class to keyring

* Address helper to obtain ImplicitAddress, cargo update

* Continue hooking up KeyRing to services

* Fix broken imports, confirm message works in popup

* Adding msg type for fetch generated mnemonic, update tests

* Beginning components package; get styled-components with theme working

* Disable devtool sourcemapping, add plugin for extension reloading (all browsers)

* Properly include svg assets, port additional components into shared
package

* Fix issue on reloader plugin

* fix module resolution, clean up imports

* Remove unnecessary assignment

* Consolidate types from Keplr into our own

* Validate mnemonic phrase before storing, better error handling in wasm

* Minor clean up, better type State class so as not to instantiate
directly

* Adding mnemonic/password creation screens, added README for types

* Split set-up flow into new tab for initial account

* Begin wiring up account derivation in service, generate implicit address
to store and return

* Add account derivation to completion process, load and display accounts

* Better error-handling, add user feedback on account creation

* Adding AccountListing components

* Clean up configs, layout, fixed bug in key storage

* Improved naming conventions, add implementation for scrypt, tests

* Implement optional custom Scrypt params

* Updated documentation

* Add aes dependency, being basic implementation

* KeyRing state is no longer duplicated, storage is only source of truth

* Add icon for copy to clipboard, additional styling, update styled config

* description -> alias to match cli, clean up

* Adding UI for adding a new derived account with basic validation

* Fix bug where alias is not being saved

* Add "alias" as a field during setup

* Updating for consistency, rough pass at styling derivation form

* Move path items to number, validate inputs, set primes appropriately

* Begin implementing kdf derived key as bytes

* Fix naming on file extension, begin components for password auth

* Add basic login/logout functionality, hook up to service backend

* Clean up effects, check keyring status on auth

* Fix minor bug when locking/unlocking wallet. Switch to numeric input

* Fix sourcemap warning, reuse lock button wrapper, minor style

* Update kdf libs for password hashing, tests, serializing params to
JsValue

* Add serializable struct and associated tests (params + bytes)

* Fix naming convention, create storage type containing params

* Moving storage updates to separate PR

* Adding support for argon2 and scrypt pbkdf hashing

* Cover Scrypt in jest tests

* Clean up

* Remove unused dependencies in this branch

* 2 more dependencies that are unneeded

* Adding dependencies

* Clean up

* Add serialize to key+params (argon2), add tests

* Fix for Cargo

* Improve custom params, add salt as an option

* Initial implementation of AES+Argon2 with related tests

* Clarify naming in jest test

* Update scrypt to accept salt, optional params, similar tests with AES

* Clean up

* Add missing test for scrypt with provided salt, clean up

* Clean up Rust lib, begin to implement encrypt/decrypt in KeyRing

* Add simple Rng mod for generating random bytes

* Touch up TS types

* clean up tests

* Connect KeyRing instance to new storage types, update UI

* Minor styling, match account hierarchy to other wallets

* Improve naming conventions, comments, updated for consistency

* Begin moving transaction args to Borsh-serialized data

* Minor style issue in rs

* Update wasm libs to support Borsh serialized data

* Define schema for remaining shared types, update tests

* Split Proxy off from InjectedAnoma, improved typing

* Simplify Message types

* Split off proxy to individual classes (proxy vs injected-proxy)

* Move borsh types to @anoma/types to decouple from wasm dependency

* Move secret out of schema, add documentation for usage in @anoma/types

* Update amount types to micro to match Namada, update tests

* Split off Signer functionality in Rust, hook up to KeyRing service

* formatting, allow more errors to return to TS from wasm

* Move types to u64 where required by Namada, lint pass, docs

* Continued improving types

* Clean up, add note to refactor Router messages

* Create RoutedMessage type, with overridable generic type arg

* Add basic Signer interface, move types to location where they can be
shared

* Update types for Signer, map TS naming conventions to Rust struct

* Set up encoding methods, move types to shared location

* Update build to support buffer, hook up encoding and signing

* Remove fail on status

* Couple minor fixes that slipped through the cracks

* Further wiring up of signTx service

* Additional message types for generating structs in wasm

* Add base64 encoding to pass binary data via postMessage

* Move other transaction message to base64 for postMessage

* Clean up unit tests, improve shared lib

* Clean-up, improve readability

* Additional test coverage

* In the case of mnemonic stored account, derive a pk to sign tx

* Clean up - remove temp comments, unnecessary checks

* Hook up ibc/init-account, fix types on chain messages

* Consistency in validation errors for KeyRing messages

* Remove duplicate types, remove cruft, fix typing, add lint to storage

* Refactored storage to fix linting issue, simplified

* Load coinType from default chain config (set to 1 for testnet/all coins)

* Updated additional derivation path, finish linting

* Additional linting item, fix very minor style issue

* Initial change to establish port, keeps Chrome service worker alive

* Updated to invoke port connection on `Anoma.connect()`

* Hashing out persisting sessions for more than 5 min

* Cleaning up test code - track timestamp to detect inactivity (TODO)

* Remove logic that was accidentally reintroduced

* Properly encode ImplicitAddress before storing

* Fix address formatting, refactor session functionality to distinct class

* Update tests, continue working with session ports

* Clean up interaction just a bit on forms, remove timestamp for now

* Move startSession call to a more appropriate place

* Timeout on inactivity is behaving properly in Chrome now

* Clean up, add cases in message handler for messages from background

* Move provider-specific messages out of background, handle session
disconnect

* Fix minor linting issues

* Add StoredRecord to Store interface

* Update KVStore usage of generic types

* Minor updates per feedback

* Remove session

* Removing unused Session.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
Development

No branches or pull requests

4 participants