Skip to content

Commit

Permalink
Conflicting args for find_validator
Browse files Browse the repository at this point in the history
  • Loading branch information
grarco committed Nov 19, 2024
1 parent b8e5e33 commit 96b87bc
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions crates/apps_lib/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7310,7 +7310,6 @@ pub mod args {
let query = Query::parse(matches);
let tm_addr = TM_ADDRESS_OPT.parse(matches);
let validator_addr = VALIDATOR_OPT.parse(matches);
// FIXME: maybe I can panic here if both are none
// FIXME: so to recap, these args are optional but at least one of
// them must be provided and both of them should never be provided
// cause it doesn't make sense FIXME: so probably we
Expand All @@ -7336,18 +7335,19 @@ pub mod args {

fn def(app: App) -> App {
app.add_args::<Query<CliTypes>>()
// FIXME: here, I believe the issue is that both args are
// optional. Is teh validator really optional though? yes
// FIXME: pobably these two should confclit with each other
.arg(
TM_ADDRESS_OPT.def().help(wrap!(
"The address of the validator in Tendermint."
)),
TM_ADDRESS_OPT
.def()
.help(wrap!(
"The address of the validator in Tendermint."
))
.conflicts_with(VALIDATOR_OPT.name),
)
.arg(
VALIDATOR_OPT
.def()
.help(wrap!("The native address of the validator.")),
.help(wrap!("The native address of the validator."))
.conflicts_with(TM_ADDRESS_OPT.name),
)
}
}
Expand Down

0 comments on commit 96b87bc

Please sign in to comment.