Merge branch 'james/mainline/dont-spawn-internal-account-vps' (#694)

* james/mainline/dont-spawn-internal-account-vps:
  Remove comment
  Update spawn_accounts to ignore implicit addresses
  Add changelog
  TestTxEnv::spawn_accounts should ignore internal addresses

.changelog/unreleased/testing/694-dont-spawn-internal-account-vps.md

@@ -0,0 +1,2 @@
+- Don't fake a wasm VP for internal addresses in tx tests
+  ([#694](https://github.com/anoma/namada/pull/694))

tests/src/vm_host_env/tx.rs

@@ -113,14 +113,23 @@ impl TestTxEnv {
         );
     }
 
-    /// Fake accounts existence by initializating their VP storage.
+    /// Fake accounts' existence by initializing their VP storage.
     /// This is needed for accounts that are being modified by a tx test to
-    /// pass account existence check in `tx_write` function.
+    /// pass account existence check in `tx_write` function. Only established
+    /// addresses ([`Address::Established`]) have their VP storage initialized,
+    /// as other types of accounts should not have wasm VPs in storage in any
+    /// case.
     pub fn spawn_accounts(
         &mut self,
         addresses: impl IntoIterator<Item = impl Borrow<Address>>,
     ) {
         for address in addresses {
+            if matches!(
+                address.borrow(),
+                Address::Internal(_) | Address::Implicit(_)
+            ) {
+                continue;
+            }
             let key = Key::validity_predicate(address.borrow());
             let vp_code = vec![];
             self.storage