Merge branch 'tiago/rm-from-u64-on-ethbridge-stake' (#1692)

* origin/tiago/rm-from-u64-on-ethbridge-stake:
  changelog: add #1692
  Call try_into() instead of into() on EthBridgeVotingPower
  Replace From<u64> with TryFrom<u64> impl on EthBridgeVotingPower
  Use new const in From impl
  Add MAX value for EthBridgeVotingPower

.changelog/unreleased/improvements/1692-rm-from-u64-on-ethbridge-stake.md

@@ -0,0 +1,2 @@
+- Removed `impl From<u64> for EthBridgeVotingPower` and replaced it with a
+  `TryFrom`. ([\#1692](https://github.com/anoma/namada/pull/1692))

core/src/types/eth_abi.rs

@@ -198,7 +198,7 @@ mod tests {
                 )
                 .expect("Test failed"),
             ],
-            voting_powers: vec![8828299.into()],
+            voting_powers: vec![8828299.try_into().unwrap()],
             epoch: 0.into(),
         };
         let encoded = valset_update.encode().into_inner();

core/src/types/voting_power.rs

@@ -31,17 +31,31 @@ use crate::types::uint::Uint;
 )]
 pub struct EthBridgeVotingPower(u64);
 
-impl From<u64> for EthBridgeVotingPower {
-    fn from(val: u64) -> Self {
-        Self(val)
+impl EthBridgeVotingPower {
+    /// Maximum value that can be represented for the voting power
+    /// stored in an Ethereum bridge smart contract.
+    pub const MAX: Self = Self(1 << 32);
+}
+
+impl TryFrom<u64> for EthBridgeVotingPower {
+    type Error = ();
+
+    #[inline]
+    fn try_from(val: u64) -> Result<Self, ()> {
+        if val <= Self::MAX.0 {
+            Ok(Self(val))
+        } else {
+            Err(())
+        }
     }
 }
 
 impl From<&FractionalVotingPower> for EthBridgeVotingPower {
     fn from(ratio: &FractionalVotingPower) -> Self {
         // normalize the voting power
         // https://github.com/anoma/ethereum-bridge/blob/fe93d2e95ddb193a759811a79c8464ad4d709c12/test/utils/utilities.js#L29
-        const NORMALIZED_VOTING_POWER: Uint = Uint::from_u64(1 << 32);
+        const NORMALIZED_VOTING_POWER: Uint =
+            Uint::from_u64(EthBridgeVotingPower::MAX.0);
 
         let voting_power = ratio.0 * NORMALIZED_VOTING_POWER;
         let voting_power = voting_power.round().to_integer().low_u64();