Merge branch 'grarco/masp-vp-expiration' (#2375)

* origin/grarco/masp-vp-expiration:
  Changelog #2375
  MASP vp validates tx expiration

.changelog/unreleased/improvements/2375-masp-vp-expiration.md

@@ -0,0 +1,2 @@
+- The MASP VP now validates the tx expiration.
+  ([\#2375](https://github.com/anoma/namada/pull/2375))

shared/src/ledger/native_vp/masp.rs

@@ -375,6 +375,14 @@ where
     ) -> Result<bool> {
         let epoch = self.ctx.get_block_epoch()?;
         let (transfer, shielded_tx) = self.ctx.get_shielded_action(tx_data)?;
+
+        if u64::from(self.ctx.get_block_height()?)
+            > u64::from(shielded_tx.expiry_height())
+        {
+            tracing::debug!("MASP transaction is expired");
+            return Ok(false);
+        }
+
         let transfer_amount = transfer
             .amount
             .to_amount(&transfer.token, &self.ctx.pre())?;