#66 Unifying data types and fake data in staking #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cleaned up staking related types
* removed empty reducers
|
I did not add tests for the actions as they are just placeholders, likely when we fetch real data we have to add some logic to the actions. |
jurevans
approved these changes
Sep 19, 2022
| myStaking: MyStaking[], | ||
| allValidators: Validator[] | ||
| ): MyValidators[] => { | ||
| // try { |
There was a problem hiding this comment.
Looks like maybe this try { was intended to be removed
| tableConfigurations={myBalancesConfigurations} | ||
| /> | ||
|
|
||
| {/* my validators */} | ||
| <Table | ||
| title="My Validators" | ||
| data={myValidatorData} | ||
| // data={myValidatorData} |
There was a problem hiding this comment.
Definitely not a big deal, but this comment could be removed.
mateuszjasiuk
deleted the
feat/66_unify_types_and_fake_data_fetching_in_staking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Validatorin staking dataFAQ
Q: Why is the data drilled down through a few layers?
A: While it is quite many, I feel that this view is very likely to change, or even be completely reshuffled for desktop/mobile. So this way maintaining several views for this data will be quick to refactor. So I feel that doing any changes in these stateless views will be very cheap.