Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aarch64 macOS agent for CI build #2754

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Use aarch64 macOS agent for CI build #2754

merged 3 commits into from
Apr 25, 2024

Conversation

paulcadman
Copy link
Collaborator

@paulcadman paulcadman commented Apr 24, 2024

This PR updates the macOS CI build to use the macos-14 build agent. This uses the M series aarch64 chips.

  • The M1 macOS agent does not have stack preinstalled so we must install it using brew before building anything.
  • The cache keys must have the runner.arch prefix to avoid building with the x86_64 cache.

The macOS build / test run in about the same time as the linux build / test, i.e significantly faster than on the x86 macOS agents.

Notes

  • We use the x86_64 binary of vamp-ir because the vamp-ir aarch64 releases do not have names that are compatible with the GitHub action we are using to download the binary releases. The x86_64 binary works fine for the purposes of testing.

@paulcadman paulcadman added the CI label Apr 24, 2024
@paulcadman paulcadman added this to the 0.6.2 milestone Apr 24, 2024
@paulcadman paulcadman self-assigned this Apr 24, 2024
@paulcadman paulcadman force-pushed the macos-m1-ci-build branch 2 times, most recently from 1be312c to 2b575ab Compare April 24, 2024 15:28
@paulcadman paulcadman marked this pull request as ready for review April 24, 2024 16:03
The M1 macOS agent does not have stack preinstalled so we must install
it using brew before building anything.

The cache keys must have the `runner.arch` prefix to avoid building with
the x86_64 cache.
The vamp-ir aarch64 release cannot be found by the
jaxxstorm/action-install-gh-release action
v1.10.0 does not support aarch64 / arm64 arch
@janmasrovira janmasrovira merged commit 778b626 into main Apr 25, 2024
4 checks passed
@janmasrovira janmasrovira deleted the macos-m1-ci-build branch April 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants