-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JuvixTree parser and pretty printer #2583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted that Asm no longer has StackRef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a look at #2592
Use `makeSem` to minimize lines and replace `send` with type annotations.
janmasrovira
approved these changes
Jan 24, 2024
paulcadman
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Implements a translation from JuvixAsm to JuvixTree. It does not work in general, but works for all code generated from Juvix and all JuvixAsm tests. * Adds the `juvix dev tree from-asm` command. * Adds tests automatically converted from JuvixAsm tests. * Depends on #2583
paulcadman
pushed a commit
that referenced
this pull request
Jan 25, 2024
janmasrovira
pushed a commit
that referenced
this pull request
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
juvix dev tree read file.jvt
command which reads and pretty prints a JuvixTree file.tree
target in thecompile
command.StackRef
in JuvixAsm. This makes JuvixAsm more consistent with JuvixTree and simplifies the data structures.StackRef
is not needed for compilation from Core.Tests for the parser will appear in a separate PR, when I implement an automatic translation of JuvixAsm to JuvixTree files.