Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Roots type to Root #2480

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Rename Roots type to Root #2480

merged 2 commits into from
Oct 30, 2023

Conversation

paulcadman
Copy link
Collaborator

@paulcadman paulcadman commented Oct 30, 2023 •
edited
Loading

This was suggested by @jonaprieto in #2458 (comment) - but we deferred it until the Package file PR sequence was merged.

@paulcadman paulcadman added this to the 0.5.3 milestone Oct 30, 2023
@paulcadman paulcadman requested a review from jonaprieto October 30, 2023 10:52
@paulcadman paulcadman self-assigned this Oct 30, 2023
@paulcadman paulcadman changed the title Rename Roots type to Roots Rename Roots type to Root Oct 30, 2023
jonaprieto
jonaprieto approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@jonaprieto jonaprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, this looks much better

@jonaprieto jonaprieto merged commit cbee146 into main Oct 30, 2023
@jonaprieto jonaprieto deleted the roots-rename branch October 30, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaprieto jonaprieto jonaprieto approved these changes

Assignees

@paulcadman paulcadman

Labels
refactor
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@paulcadman @jonaprieto