Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated implicit pattern check from scoper #2357

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Remove duplicated implicit pattern check from scoper #2357

merged 1 commit into from
Sep 13, 2023

Conversation

paulcadman
Copy link
Collaborator

@paulcadman paulcadman commented Sep 13, 2023 •
edited
Loading

This PR removes the CaseBranchImplicit error from the scoper. This error is already handled in the arity/typechecker with a good error message:

The arity checker error message for

   case b of {
      | {{true}} := false

is

Expected an explicit pattern but found an implicit instance pattern: {{true}}

@paulcadman
Remove duplicated implicit pattern check from scoper
ec7e12a 
THe arity/typechecker already handles this error with a good error message
@paulcadman paulcadman self-assigned this Sep 13, 2023
@paulcadman paulcadman mentioned this pull request Sep 13, 2023
Merged
@paulcadman paulcadman added this to the 0.5.0 milestone Sep 13, 2023
@janmasrovira janmasrovira merged commit 327cfaa into main Sep 13, 2023
@janmasrovira janmasrovira deleted the remove-dup-implicit-pattern-error branch September 13, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira janmasrovira approved these changes

Assignees

@paulcadman paulcadman

Labels
error-messaging refactor
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Remove ErrCaseBranchImplicitPattern
2 participants
@paulcadman @janmasrovira