Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VampIR range checks and error handling #2344

Merged
merged 4 commits into from
Sep 12, 2023
Merged

VampIR range checks and error handling #2344

merged 4 commits into from
Sep 12, 2023

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Sep 6, 2023 •
edited
Loading

  • Adds range checks and proper error handling to the Juvix-to-VampIR pipeline.
  • Adds the --unsafe option which disables the checks.

@lukaszcz lukaszcz added enhancement New feature or request pipeline:vampir labels Sep 6, 2023
@lukaszcz lukaszcz added this to the 0.5 milestone Sep 6, 2023
@lukaszcz lukaszcz self-assigned this Sep 6, 2023
@lukaszcz lukaszcz changed the title VampIR range checks & error handling VampIR range checks and error handling Sep 6, 2023
@lukaszcz lukaszcz marked this pull request as ready for review September 7, 2023 10:39
@lukaszcz lukaszcz requested a review from jonaprieto September 7, 2023 14:16
jonaprieto
jonaprieto reviewed Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@jonaprieto jonaprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include a smoke test to test that new flag and the output

@lukaszcz lukaszcz force-pushed the vampir-pipeline-update branch from a475e35 to ce7baad Compare September 7, 2023 16:31
@lukaszcz lukaszcz requested a review from jonaprieto September 7, 2023 18:01
@lukaszcz lukaszcz force-pushed the vampir-pipeline-update branch from b5a50e7 to d470f97 Compare September 8, 2023 10:17
@jonaprieto jonaprieto force-pushed the vampir-pipeline-update branch from d470f97 to 11012ae Compare September 12, 2023 11:33
@jonaprieto jonaprieto merged commit 1710615 into main Sep 12, 2023
@jonaprieto jonaprieto deleted the vampir-pipeline-update branch September 12, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaprieto jonaprieto jonaprieto approved these changes

@janmasrovira janmasrovira janmasrovira approved these changes

Assignees

@lukaszcz lukaszcz

Labels
enhancement New feature or request pipeline:vampir
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszcz @jonaprieto @janmasrovira