Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css colors ju-comment and ju-judoc #2321

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Add css colors ju-comment and ju-judoc #2321

merged 3 commits into from
Aug 30, 2023

Conversation

janmasrovira
Copy link
Collaborator

This pr adds colors for comments and judoc for the html backend

@janmasrovira janmasrovira added this to the 0.4.4 milestone Aug 29, 2023
@janmasrovira janmasrovira self-assigned this Aug 29, 2023
@jonaprieto
Copy link
Collaborator

Idea. Perhaps we can think about generating these color schemes automatically.
They are simple enough, and during the process, we can make sure the CSS
stylesheets define all the colors we need, one for each face.

Also, we could offer some customisation, perhaps by exposing
some optional fields in the package Yaml to redefine the default
colors and other info, like the title or footer.
For example, we could do something like:

# juvix.yaml
...
html:
  theme: dark
  colors:
  - comment: #c3c3c3
  - delimiter: #F3f3F3
  ...
...

@janmasrovira
Copy link
Collaborator Author

janmasrovira commented Aug 30, 2023

Idea. Perhaps we can think about generating these color schemes automatically. They are simple enough, and during the process, we can make sure the CSS stylesheets define all the colors we need, one for each face.

We can explore that, as it would offer more safety.

Also, we could offer some customisation, perhaps by exposing some optional fields in the package Yaml to redefine the default colors and other info, like the title or footer. For example, we could do something like:

# juvix.yaml
...
html:
  theme: dark
  colors:
  - comment: #c3c3c3
  - delimiter: #F3f3F3
  ...
...

I'm not 100% convinced about using the juvix.yaml file for that. Maybe we can offer the user the option to pass a custom css file as an argument to the cli. The juvix.yaml file could then have an optional field that points to that custom css file.
Either way, let's discuss this in a separate issue.

@jonaprieto
Copy link
Collaborator

I'll open an issue to continue this discussion later.

using the juvix.yaml file for that.

Why not? this usage example is a particular case, the way I see it, of providing specific parameters/input to the backend target for the build process.

@jonaprieto jonaprieto merged commit 92714b8 into main Aug 30, 2023
@jonaprieto jonaprieto deleted the html-add-colors branch August 30, 2023 13:55
@jonaprieto jonaprieto modified the milestones: 0.4.4, 0.5 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants