Report termination errors after typechecking #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
termination-errors-after-typechecking
branch
2 times, most recently
from
6763bc9 to
d4340ea
Compare
paulcadman
force-pushed
the
termination-errors-after-typechecking
branch
from
6abbe3b to
300baa2
Compare
jonaprieto
reviewed
Aug 30, 2023
...vix/Compiler/Internal/Translation/FromInternal/Analysis/Termination/Data/TerminationState.hs
Outdated
Show resolved
Hide resolved
jonaprieto
reviewed
Aug 30, 2023
src/Juvix/Compiler/Internal/Translation/FromInternal/Analysis/Termination/Checker.hs
Outdated
Show resolved
Hide resolved
jonaprieto
approved these changes
Aug 30, 2023
jonaprieto
force-pushed
the
termination-errors-after-typechecking
branch
from
1c41d42 to
75b24f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an effect for termination. It keeps track of which functions failed the termination checker, which is run just after translating to Internal. During typechecking, non-terminating functions are not normalized. After typechecking, if there is at least one function which failed the termination checker, an error is reported.
Additionally, we now properly check for termination of functions defined in a let expression in the repl.