Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typcheck imports before statements #2253

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Typcheck imports before statements #2253

merged 2 commits into from
Jul 11, 2023

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira self-assigned this Jul 10, 2023
@janmasrovira janmasrovira linked an issue Jul 10, 2023 that may be closed by this pull request
Typecheck error when using 'type aliases' via imports (regression since 0.4.1) #2248
Closed
@janmasrovira janmasrovira changed the title Fixes imported type aliases Typcheck imports before statements Jul 10, 2023
@janmasrovira janmasrovira requested a review from paulcadman July 10, 2023 20:21
@janmasrovira janmasrovira marked this pull request as ready for review July 10, 2023 20:21
@paulcadman paulcadman force-pushed the 2248-typecheck-error-when-using-type-aliases-via-imports-regression-since-041 branch from a4ab8a2 to 898902d Compare July 11, 2023 09:16
@janmasrovira janmasrovira force-pushed the 2248-typecheck-error-when-using-type-aliases-via-imports-regression-since-041 branch from 898902d to 4672852 Compare July 11, 2023 09:45
@janmasrovira janmasrovira merged commit 9fdf848 into main Jul 11, 2023
@janmasrovira janmasrovira deleted the 2248-typecheck-error-when-using-type-aliases-via-imports-regression-since-041 branch July 11, 2023 10:26
@lukaszcz lukaszcz added this to the 0.4.3 milestone Jul 24, 2023
@jonaprieto jonaprieto modified the milestones: 0.4.3, 0.4.2 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

Assignees

@janmasrovira janmasrovira

Labels
fix:bug
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.

Typecheck error when using 'type aliases' via imports (regression since 0.4.1)
4 participants
@janmasrovira @paulcadman @lukaszcz @jonaprieto