Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor isValidChar #2194

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Refactor isValidChar #2194

merged 2 commits into from
Jun 16, 2023

Conversation

jonaprieto
Copy link
Collaborator

Move common functions to Prelude

@jonaprieto jonaprieto requested a review from lukaszcz June 15, 2023 17:56
lukaszcz
lukaszcz requested changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@lukaszcz lukaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's name it more descriptively if we're making it global, e.g., isValidIdentChar.

A potential problem with this is that in the future valid VampIR names and valid C names might be different - then we'll need two functions again.

@lukaszcz lukaszcz merged commit 56cde34 into main Jun 16, 2023
@lukaszcz lukaszcz deleted the small-refactor branch June 16, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszcz lukaszcz lukaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonaprieto @lukaszcz