-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: pprint positive kw for data types #1980
Conversation
Printing keyword annotations onto separate lines probably requires more discussion. My opinion is that it's inconsistent with other keywords. For example we don't format
|
Sure! open discussion
My preference for this formatting is based on the fact that it can be helpful when refactoring or testing code. When each annotation is commented on its line, it becomes easier to modify them without affecting the rest of its terms. Like minimizing the diff mark. Also, in each case you mentioned, if you were to comment or uncomment the corresponding keyword line, it would effectively render the statement invalid. Annotations like terminating, builtins, or even axioms act as attributes to the term, and they may be removed later. |
OK - let's do it 🚀 ! Suggestion: Update the language reference formatting: juvix/docs/reference/language/axioms.md Line 10 in 046e82b
|
As the title says. Additionally, I fix references to stack and juvix binaries.
Done, I updated the excerpts in the documentation I saw. Likely, I forgot some, so we need to review the format later, so I'll leave this for another pr if it's ok with you. |
As the title says.
I found this bug while formatting the examples found in the tests folder.
In addition to printing the missing positive' keyword for data types, the code also prints certain keyword annotations onto separate lines, the ones that act as attributes to their term. While this is a matter of personal preference, I find that it makes it easier to comment and uncomment individual annotations.